Skip to content

Fix: FightingWho secret string comparison error during combat #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Amadeus- wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix: FightingWho secret string comparison error during combat #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions Tracker_DamageMeter.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -745,8 +745,11 @@ local function SnapshotSession(verbose)
DP(" who.Name is nil, cannot store damage secrets")
end

if source.isLocalPlayer and Recount.FightingWho == "" then
Recount.FightingWho = GENERIC_FIGHT_NAME
if source.isLocalPlayer then
local fwOk, fwEmpty = pcall(function() return Recount.FightingWho == "" end)
if fwOk and fwEmpty then
Recount.FightingWho = GENERIC_FIGHT_NAME
end
end
end
end
Expand Down Expand Up @@ -843,7 +846,8 @@ local function UpdateTick()
end

if found then
if Recount.FightingWho == "" then
local fwOk2, fwEmpty2 = pcall(function() return Recount.FightingWho == "" end)
if fwOk2 and fwEmpty2 then
Recount.FightingWho = GENERIC_FIGHT_NAME
end
Recount.NewData = true
Expand Down Expand Up @@ -893,11 +897,14 @@ local function OnCombatEnd()

ParseSessionFull()

if Recount.FightingWho == "" then
local fwOk3, fwEmpty3 = pcall(function() return Recount.FightingWho == "" end)
if fwOk3 and fwEmpty3 then
Recount.FightingWho = GENERIC_FIGHT_NAME
end

DP("Calling LeaveCombat, FightingWho=" .. Recount.FightingWho)
local fwStr = ""
pcall(function() fwStr = Recount.FightingWho end)
DP("Calling LeaveCombat, FightingWho=" .. tostring(fwStr))
Recount:LeaveCombat(GetTime())
Recount:FullRefreshMainWindow()

Expand Down