Actually invoke OnMouseUp handler after window scale changes#21
Open
Amadeus- wants to merge 1 commit intoResike:mainfrom
Open
Actually invoke OnMouseUp handler after window scale changes#21Amadeus- wants to merge 1 commit intoResike:mainfrom
Amadeus- wants to merge 1 commit intoResike:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In WindowOrder.lua, when windows are rescaled the code grabs the OnMouseUp to trigger position saving, but it never actually calls the returned function — the result is just silently thrown away. This means window positions aren't properly saved after a scale change.
Fixed by calling the returned handler with (v, "LeftButton") to match the standard OnMouseUp signature. This has been broken since before the Midnight migration.