Fix potential secret value crash in font string width checks#19
Open
Amadeus- wants to merge 1 commit intoResike:mainfrom
Open
Fix potential secret value crash in font string width checks#19Amadeus- wants to merge 1 commit intoResike:mainfrom
Amadeus- wants to merge 1 commit intoResike:mainfrom
Conversation
…eckFontStringLength
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WrapFontString and CheckFontStringLength both loop comparing GetStringWidth() against a max width. In Midnight, GetStringWidth() can return a secret value in tainted execution contexts, and the > comparison throws an error.
Added the same pcall + issecretvalue guard pattern that's already used in GUI_Main.lua's FixRow function — wrap the call in pcall, check the result is a real number and not secret, bail out of the loop otherwise.