Skip to content

Conversation

@J164
Copy link
Member

@J164 J164 commented Sep 18, 2025

No description provided.

@J164 J164 requested review from a team and Copilot September 18, 2025 22:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR modifies the GET /subscription endpoint to deduplicate subscriptions by mailing list, aggregating user IDs for each unique mailing list instead of returning individual subscription records.

  • Implemented aggregation logic to group subscriptions by mailing list with arrays of user IDs
  • Updated the response format from individual subscription objects to aggregated objects with mailingList and userIds properties
  • Added comprehensive test coverage for the new aggregation behavior

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
src/services/subscription/subscription-router.ts Added reduce operation to aggregate subscriptions by mailing list
src/services/subscription/subscription-router.test.ts Updated existing test and added new test for multiple mailing lists aggregation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Timothy-Gonzalez Timothy-Gonzalez merged commit f494da9 into main Sep 18, 2025
5 checks passed
@Timothy-Gonzalez Timothy-Gonzalez deleted the deduplicate-subscriptions branch September 18, 2025 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants