Use timeout instead of num_sec#199
Open
LadislavVasina1 wants to merge 1 commit into
Open
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideReplace deprecated wait_for num_sec parameter and string-based timeout usage with the new timeout integer parameter across chipgroup, navigation, and pagination components and tests. Sequence diagram for wait_for timeout usage in chipgroupsequenceDiagram
participant Chip as Chip
participant Button as ChipButton
participant wait_for as wait_for
Chip->>Button: click()
Chip->>wait_for: wait_for(_gone, timeout=3, delay=0.1, message="wait for chip to disappear")
wait_for-->>Chip: _gone returns True
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
Author
|
pre-commit.ci autofix |
mshriver
approved these changes
Jun 2, 2026
Contributor
|
the gitlab workflows for the legacy branch will require updates to continue to function. |
Author
|
@mshriver should it be fixed within this PR? |
vsedmik
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Future release of wait_for will deprecate
num_secparameter and timeout usage with time as a string value.This PR makes changes based on this.
Related PRs:
RedHatQE/widgetastic.core#309
RedHatQE/widgetastic.patternfly5#125
Summary by Sourcery
Update wait_for usage to rely on the timeout parameter instead of the deprecated num_sec and string-based time values.
Enhancements:
Tests: