enable the Sast coverity check

[MichaelMraka]

Secure Coding Practices Checklist GitHub Link

• https://github.com/RedHatInsights/secure-coding-checklist

Secure Coding Checklist

• Input Validation
• Output Encoding
• Authentication and Password Management
• Session Management
• Access Control
• Cryptographic Practices
• Error Handling and Logging
• Data Protection
• Communication Security
• System Configuration
• Database Security
• File Management
• Memory Management
• General Coding Practices

Summary by Sourcery

Build:

• Pass skip-sast-coverity-check=false to the docker-build-oci-ta Tekton pipeline for both pull request and push workflows to activate Coverity SAST scanning.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR enables the SAST Coverity check in the Tekton CI pipelines by wiring a new skip flag parameter and defaulting it to run for both pull request and push workflows.

File-Level Changes

Change	Details	Files
Enable Coverity SAST check in the pull-request Tekton pipeline by adding a configurable skip flag parameter defaulted to false.	Introduce a new Tekton parameter to control skipping of the SAST Coverity check. Set the parameter value to "false" so the SAST check is executed for pull-request builds by default. Pass the parameter through to the existing docker-build-oci-ta pipeline via the pipelineRef configuration.	.tekton/patchman-engine-pull-request.yaml
Enable Coverity SAST check in the push Tekton pipeline by adding a configurable skip flag parameter defaulted to false.	Introduce the same skip-sast-coverity-check parameter to the push pipeline configuration. Default the parameter value to "false" so SAST runs on push events as well. Ensure the parameter is wired into the docker-build-oci-ta pipeline invocation for push builds.	.tekton/patchman-engine-push.yaml

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The new skip-sast-coverity-check parameter is duplicated in both the pull-request and push Tekton configs; consider centralizing this configuration (e.g., via a shared template or value file) so future changes to the flag only need to be made in one place.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The new `skip-sast-coverity-check` parameter is duplicated in both the pull-request and push Tekton configs; consider centralizing this configuration (e.g., via a shared template or value file) so future changes to the flag only need to be made in one place.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.23%. Comparing base (e91c723) to head (c9615c3).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #2211   +/-   ##
=======================================
  Coverage   59.23%   59.23%           
=======================================
  Files         137      137           
  Lines        8795     8795           
=======================================
  Hits         5210     5210           
  Misses       3037     3037           
  Partials      548      548           

Flag	Coverage Δ
unittests	59.23% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[MichaelMraka]

/retest