feat(NGUI-223): A2A protocol support (dev preview) - package and container image #149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
velias
reviewed
Sep 4, 2025
lkrzyzanek
changed the title
Collaborator
|
The code looks good. Just a general comment that I would make README.md less code heavy and more text. I don't think it makes a lot of sense having the same code in readme and in separate python files. They will surely get out of sync at some point and it would be easier to just point to the right file and explain from a high level what it is doing or what it is useful for. |
lkrzyzanek
force-pushed
the
a2a
branch
2 times, most recently
from
5de3775 to
3c1a286
Compare
lkrzyzanek
changed the title
unibrew
approved these changes
Nov 25, 2025
velias
reviewed
Nov 25, 2025
Collaborator
velias
left a comment
velias
left a comment
There was a problem hiding this comment.
Looks good, few notes, mainly towards documentation or additional features
lkrzyzanek
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A2A protocol support.
See README.md
Related: lightspeed-core/lightspeed-stack#727