Open
Conversation
…d fetching non-existent wallets and erroring
Collaborator
Author
|
A pass will be needed to construct the proper error with code and message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes constitute the vast majority of lookup logic and route definitions for the
lookup/namesendpoints to reach compatibility with Krist.Note that testing and acceptance criteria may need to be outlined a little bit better to ensure the API usage and database side effects are correct for these routes. Based on my testing, I believe it to be mostly correct, but could use some eyes on this from someone more familiar with how Krist operates.
Currently, the PR only targets the names lookups, but I will attempt to add in the one last lookup required for
transactions/{addresses}. That should be in a future commit.If possible, please pull these changes and verify before merging into main.
Thanks!