Resource packs #276
Open
Resource packs #276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Un1q32
force-pushed
the
resource-packs
branch
from
1a46f3c to
76dd72c
Compare
before if vanilla didnt have default8.png but a resource pack did, the game wouldn't use the resource pack's default8.png
BrentDaMage
requested changes
Jan 19, 2026
source/client/sound/SoundData.cpp
Outdated
| { | ||
| #define SOUND(category, name) SA_##name._load(platform, #category, #name); | ||
| #define SOUND_NUM(category, name, number) SA_##name##number._load(platform, #category, #name#number); | ||
| #define SOUND(category, name) SA_##name._load(options, platform, #category, #name); |
Collaborator
There was a problem hiding this comment.
Do not do this, find a better way.
Collaborator
There was a problem hiding this comment.
Pass a pointer to Minecraft or something, that way it can call getOptions() and platform()
|
|
||
| template <class TVisitor> | ||
| void visitBFS(TVisitor& visitor) | ||
| void visitBFS(TVisitor& visitor, const std::vector<std::string>& resourcepacks) |
Collaborator
There was a problem hiding this comment.
Dude no. Absolutely not. Do not pollute shared utility code with resourcepack stuff. Never do this. If you have questions during implementation, please ask me.
source/renderer/ShaderGroup.cpp
Outdated
| if (Util::isValidPath(codeOrPath)) | ||
| { | ||
| programCode = AppPlatform::singleton()->readAssetFileStr(codeOrPath, true); | ||
| programCode = AppPlatform::singleton()->readAssetFileStr(codeOrPath, true, resourcepacks); |
Collaborator
There was a problem hiding this comment.
To get a better idea as to how this can be done cleanly, we should check what PE is doing.
Contributor
Author
There was a problem hiding this comment.
PE only added resource packs in 0.15 which is after they removed symbols, I'm not decomping that.
Un1q32
force-pushed
the
resource-packs
branch
from
fa11182 to
78ab566
Compare
Un1q32
force-pushed
the
resource-packs
branch
from
11f7cad to
ae81973
Compare
This reverts commit e77a269.
saves performance since we don't have to check for assets in non-existent packs, plus it's consistent with what mojang does IIRC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First prototype of resource packs.
Resource packs are an overlay over the assets directory, stored in
games/com.mojang/resource_packs/packname.There is no UI for managing resource packs, you must manually edit options.txt.
You can enable a resource pack by setting
gfx_resourcepackstopackname, you can enable multiple resource packs by setting it topackname1,packname2,packname3.Other stuff:
Made m_externalStorageDir a property of AppPlatform.
Closes #274