Skip to content

build: update design system to v2.6.2 #1261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

build: update design system to v2.6.2 #1261

wants to merge 9 commits into from

Conversation

@maxelkins
Copy link
Contributor

@maxelkins maxelkins commented Oct 17, 2025 •
edited
Loading

Closes https://github.com/RaspberryPiFoundation/digital-editor-issues/issues/968

Summary

Update to the latest design system to take advantage of new components and features.

Done so far

  • Incrementally updated - see commits
  • Ran all tests at each commit
  • Followed design system updating guide for v2+
  • Fixed any breaking changes - only 1 (see commits details)
  • Added material icon font to host (web component preview page)

Issues / To do

  • Some styles appear to be broken/missing
  • (note this is only when "use_editor_styles" isn't true, which currently has missing styles)
  • I suspect this is because editor-ui is overriding design-system-core classes style rather than overriding custom properties - which would normally avoid most breaking changes. Largely "core breaking component changes" only affect upstream packages (react/rails).
Screenshot 2025-10-17 at 11 20 17

To get this out...

Quick fix:

  • Modfiy default theming to fix broken styling (that isnt already missing)

Ideally:

  • Check core changelog for breaking changes and compare that with design system overrides (most likely the button)
  • Migrate to theming using the css custom properties
  • Use of material icons font broken in web component - existing issue
  • Migrate to using design system buttons - See PR.

@maxelkins
build: update design system react to 1.7.0
4b9672a
@maxelkins
build: update design system react to 2.0.0
63dbd43 
- 2.0.0 uses vite and packages core, so that dep can removed.
- Link to core style does however need to be added to the app, following the update guide for the design system.
- TextEncoder/TextDecoder was not set up in jest and this was causing some design system component to fail tests.
@maxelkins
build: update design system react to 2.1.0
b7d593a
@maxelkins
build: update design system react to 2.2.0
e4a59b9 
- No buttons using href prop so no changes needed
@maxelkins
build: update design system react to 2.3.0
652d022
@maxelkins
build: update design system react to 2.4.2
8817520
@maxelkins
build: update design system react to 2.5.0
96507ef
@maxelkins
build: update design system react to 2.6.2
0da9ed7
@maxelkins maxelkins temporarily deployed to previews/1261/merge October 17, 2025 10:18 — with GitHub Actions Inactive
@maxelkins maxelkins mentioned this pull request Oct 17, 2025
Draft
12 tasks
@maxelkins maxelkins changed the title Update design system to v2.6.2 build: update design system to v2.6.2 Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@maxelkins