Skip to content

Conversation

cj401-amd
Copy link

Motivation

  • update protobuf to 6.32.1

i-chaochen

This comment was marked as duplicate.

opt_einsum ~= 3.3.0
packaging ~= 23.2
protobuf ~= 3.20.3
protobuf ~= 6.32.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this change only for docker image, isn't?

Copy link
Author

@cj401-amd cj401-amd Oct 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6.32.1 was put on the docker container when reinstall the re-built whl for https://ontrack-internal.amd.com/browse/SWDEV-556295, it works. the original one is 3.20.3. not sure the protobuf version will be affecting other stuff.

@i-chaochen
Copy link
Collaborator

is it because we haven't done weekly-sync on tensorflow to cause us to update this protobuf? @hsharsha

@hsharsha
Copy link

is it because we haven't done weekly-sync on tensorflow to cause us to update this protobuf? @hsharsha

No upstream still points to old 3.20.3 -> https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/tf_sig_build_dockerfiles/devel.requirements.txt#L18

@i-chaochen
Copy link
Collaborator

i-chaochen commented Oct 16, 2025

upstream has already bump to a newer protobuf https://github.com/tensorflow/tensorflow/blob/master/ci/official/requirements_updater/requirements.in#L26

I think we shall have it next weekly-sync and switch to ci/official from tools/tf_sig_build_dockerfiles

@hsharsha
Copy link

But 3.20.3 is causing seg fault with tf2 DLM models as well as has issues in jax profiler data collection with roc-profiler-sdk3 according to @cj401-amd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants