-
Notifications
You must be signed in to change notification settings - Fork 100
update protobuf to 6.32.1 #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-upstream
Are you sure you want to change the base?
Conversation
opt_einsum ~= 3.3.0 | ||
packaging ~= 23.2 | ||
protobuf ~= 3.20.3 | ||
protobuf ~= 6.32.1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does this change only for docker image, isn't?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6.32.1 was put on the docker container when reinstall the re-built whl for https://ontrack-internal.amd.com/browse/SWDEV-556295, it works. the original one is 3.20.3. not sure the protobuf version will be affecting other stuff.
is it because we haven't done weekly-sync on tensorflow to cause us to update this protobuf? @hsharsha |
No upstream still points to old 3.20.3 -> https://github.com/tensorflow/tensorflow/blob/master/tensorflow/tools/tf_sig_build_dockerfiles/devel.requirements.txt#L18 |
upstream has already bump to a newer protobuf https://github.com/tensorflow/tensorflow/blob/master/ci/official/requirements_updater/requirements.in#L26 I think we shall have it next weekly-sync and switch to ci/official from tools/tf_sig_build_dockerfiles |
But 3.20.3 is causing seg fault with tf2 DLM models as well as has issues in jax profiler data collection with roc-profiler-sdk3 according to @cj401-amd |
Motivation