Skip to content

[Test] Add vllm_ut test#44

Open
pranavprakash-amd wants to merge 2 commits into
mainfrom
users/pranavprakash-amd/vllm_ut
Open

[Test] Add vllm_ut test#44
pranavprakash-amd wants to merge 2 commits into
mainfrom
users/pranavprakash-amd/vllm_ut

Conversation

@pranavprakash-amd

Copy link
Copy Markdown

Motivation

Adding test to validate vllm specific scenarios

Technical Details

Test Plan

Test Result

Submission Checklist

Signed-off-by: Prakash <prapraka@amd.com>
Signed-off-by: Prakash <prapraka@amd.com>
@pranavprakash-amd pranavprakash-amd requested a review from a team as a code owner July 15, 2026 12:49
@pranavprakash-amd pranavprakash-amd changed the title Users/pranavprakash amd/vllm ut [Test] Add vllm_ut test Jul 15, 2026

@y1k2chaitanya y1k2chaitanya left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review — 1 blocker (required CI check failing):

  • pre-commit (black --check) is FAILINGblack would reformat both new files, so this required gate is red and blocks merge. Run black tests/frameworks/vllm/ and push. Specifics:
    • tests/frameworks/vllm/conftest.py:96 — needs a blank line after import logging, the any(...) generator collapsed to one line (~L102), and the final pytest.skip(...) collapsed (~L115).
    • tests/frameworks/vllm/test_vllm_ut.py:167 — collapse the split apt-get ... "curl libsodium23" string, and reformat the three commands.extend([...]) blocks (~L177-L208) and the tests-tree commands.extend([...]) (~L214) to black's style.

Non-blocking nits (no action required to approve): module docstrings reference the path tests/e2e/frameworks/vllm/ but the files live at tests/frameworks/vllm/.

All imports (framework.reporting.allure_reporter.report_metric), the container_executor fixture, probe()/run(), and the --no-gpu/--container-image options resolve, and the dotted markers match the registered taxonomy — so once black passes this is otherwise mergeable.

@@ -0,0 +1,2 @@
# Copyright Advanced Micro Devices, Inc.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

vllm tests placeholder may be ./tests/e2e//test_vllm_ut.py

@pytest.mark.ci.weekly
@pytest.mark.layer.runtime
@pytest.mark.runtime.soak
@pytest.mark.os.linux

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update per directory category profiles in frameworks/markers/taxonomy.py

@pranavprakash-amd

pranavprakash-amd commented Jul 16, 2026

Copy link
Copy Markdown
Author

Run result::

====================================================== ROCm Test Suite Summary ======================================================
Test Directory PASS FAIL SKIP ERROR Duration
─────────────────────────────────────────────────────────────
tests/frameworks/vllm 0 8 0 0 1726.2 s
─────────────────────────────────────────────────────────────
TOTAL 8 tests │ 0 passed │ 8 failed │ 0 skipped │ 0 error │ 1726.2 s

Failed tests:
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[core]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[test_regression_py]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[engine_test_sequence_py_test_config_py_test_logger_py]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[tokenization]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[test_logits_processor_py]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[tool_use]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut[kernels_quantization_test_awq_triton_py]
• tests/frameworks/vllm/test_vllm_ut.py::test_vllm_ut_int4_awq_triton

Note: The failures are part of the pytest tests that are triggered inside the vllm. Those failures are not because of the current test as its just invoking them inside the container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants