[Test] Add vllm_ut test#44
Conversation
Signed-off-by: Prakash <prapraka@amd.com>
Signed-off-by: Prakash <prapraka@amd.com>
y1k2chaitanya
left a comment
There was a problem hiding this comment.
Automated review — 1 blocker (required CI check failing):
pre-commit(black --check) is FAILING →blackwould reformat both new files, so this required gate is red and blocks merge. Runblack tests/frameworks/vllm/and push. Specifics:tests/frameworks/vllm/conftest.py:96— needs a blank line afterimport logging, theany(...)generator collapsed to one line (~L102), and the finalpytest.skip(...)collapsed (~L115).tests/frameworks/vllm/test_vllm_ut.py:167— collapse the splitapt-get ... "curl libsodium23"string, and reformat the threecommands.extend([...])blocks (~L177-L208) and the tests-treecommands.extend([...])(~L214) to black's style.
Non-blocking nits (no action required to approve): module docstrings reference the path tests/e2e/frameworks/vllm/ but the files live at tests/frameworks/vllm/.
All imports (framework.reporting.allure_reporter.report_metric), the container_executor fixture, probe()/run(), and the --no-gpu/--container-image options resolve, and the dotted markers match the registered taxonomy — so once black passes this is otherwise mergeable.
| @@ -0,0 +1,2 @@ | |||
| # Copyright Advanced Micro Devices, Inc. | |||
There was a problem hiding this comment.
vllm tests placeholder may be ./tests/e2e//test_vllm_ut.py
| @pytest.mark.ci.weekly | ||
| @pytest.mark.layer.runtime | ||
| @pytest.mark.runtime.soak | ||
| @pytest.mark.os.linux |
There was a problem hiding this comment.
update per directory category profiles in frameworks/markers/taxonomy.py
|
Run result:: ====================================================== ROCm Test Suite Summary ====================================================== Failed tests: Note: The failures are part of the pytest tests that are triggered inside the vllm. Those failures are not because of the current test as its just invoking them inside the container. |
Motivation
Adding test to validate vllm specific scenarios
Technical Details
Test Plan
Test Result
Submission Checklist