-
Notifications
You must be signed in to change notification settings - Fork 17
[Documentation]: Document user-facing iris.hip module APIs #188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ion page Co-authored-by: mawad-amd <[email protected]>
docs/reference/api-hip-module.md
Outdated
|
||
### set_device | ||
```{eval-rst} | ||
.. autofunction:: iris.hip.set_device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot some APIs here are not used in the code base. If they are not used, remove them. If they are not used in the examples or tests, also remove them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 4 unused functions from the hip module: get_arch_string
, hip_malloc
, malloc_fine_grained
, and hip_free
. All remaining 11 functions are either used directly in the codebase (iris.py, examples, tests) or used internally by other functions. Commit: SHORT_HASH
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot some apis are internal usage only. we dont need to expose them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed 4 internal APIs from documentation: hip_try
, hipIpcMemHandle_t
, get_device_id
, and get_rocm_version
. These remain in the code for internal use but are no longer exposed in the public API docs. Only 7 public APIs are now documented. Commit: 449f300
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot are set and count_devices devices used? get_ipc_handle and open_ipc_handle are internal usage only. Move them into internal or a detail file. I only want functions used in examples to be documented and part of hip module.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated documentation to include only APIs used in examples/tests. Now documenting only 2 functions:
get_wall_clock_rate
(used in 6 GEMM examples)get_num_xcc
(used in tests)
Removed from documentation: set_device
, count_devices
, get_cu_count
, get_ipc_handle
, open_ipc_handle
(all internal use only). Commit: b8778e6
…oc_fine_grained, hip_free) Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
Co-authored-by: mawad-amd <[email protected]>
iris/hip.py
Outdated
""" | ||
Get the number of XCCs (Compute Dies) for a HIP device. | ||
XCC (eXtended Compute Complex) refers to the compute dies in MI300 series GPUs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot XCC Accelerated Compute Core
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated XCC acronym definition to "Accelerated Compute Core" in the docstring. Commit: a36e9a1
Co-authored-by: mawad-amd <[email protected]>
Documentation for iris.hip module
Final documented APIs (2 functions):
get_wall_clock_rate()
- Used in 6 GEMM examples for GPU frequency queriesget_num_xcc()
- Used in unit tests for XCC (Accelerated Compute Core) count queriesNot documented (internal use only):
set_device
,get_cu_count
,count_devices
- Used internally by iris.pyget_ipc_handle
,open_ipc_handle
- Used internally for IPC operationship_try
,hipIpcMemHandle_t
,get_device_id
,get_rocm_version
- Internal helpersOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.