rocFile: Test stream destructor without leaking memory. #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-turbofish
requested review from
derobins,
gaoikawa,
kurtmcmillan and
riley-dixon
as code owners
jordan-turbofish
force-pushed
the
jpatters/stream-destructor-text-update
branch
from
da4595f to
18c61d2
Compare
kurtmcmillan
approved these changes
Nov 20, 2025
jordan-turbofish
force-pushed
the
jpatters/stream-destructor-text-update
branch
from
18c61d2 to
3d0d1cf
Compare
jordan-turbofish
force-pushed
the
jpatters/stream-destructor-text-update
branch
from
3d0d1cf to
45215c3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test was originally written to test the static DriverState, in which case we needed to leak the shared_ptr to test the destructor. When using the object directly, we can just limit its scope so it is destructed before the shared_ptr.