Skip to content

fix(promote-strided): include hip.npi_* ops in strided-input promotion #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
kirankumarmatam-amd wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

fix(promote-strided): include hip.npi_* ops in strided-input promotion #625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1184a63
fix(promote-strided): include hip.npi_* ops in strided-input promotion
kirankumarmatam-amd Aug 1, 2026
07eedbc
fix(promote-strided): tighten comment and restore blank line
kirankumarmatam-amd Aug 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion lib/Dialect/Transforms/PromoteStridedHipOperands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,8 +147,15 @@ void PromoteStridedHipOperandsPass::runOnOperation() {
// ops) does not invalidate the walk.
SmallVector<DestinationStyleOpInterface> consumers;
funcOp.walk([&](DestinationStyleOpInterface dpsOp) {
// Match on op-name prefix rather than dialect object: NPI plugin ops
// (hip.npi_quantize, hip.npi_dequantize, etc.) live in NpiDialect but
// carry "hip.*" names and the same contiguous-pointer ABI. The old
// dialect-object check excluded them, causing strided subview inputs
// (e.g. Q/K/V slices from onnx.Split) to be passed uncopied to NPI
// kernels that read them as flat arrays, producing wrong values.
Operation *op = dpsOp.getOperation();
if (op->getDialect() != op->getContext()->getLoadedDialect<HipDialect>())
llvm::StringRef fullOpName = op->getName().getStringRef();
if (!fullOpName.starts_with("hip."))
return;
consumers.push_back(dpsOp);
});
Expand Down
Loading