feat(hipsr): add expand LLVM lowering - #585
Draft
mingyueliuh wants to merge 2 commits into
Draft
Conversation
mingyueliuh
requested review from
amd-mingw,
edelaye,
fhanuman,
qianglin-amd and
wcy123
as code owners
July 29, 2026 10:08
|
Thanks for opening a PR! This project follows LLVM's incremental-development and AI-tool-use Before requesting review, please check that:
Reviewers are assigned through |
mingyueliuh
marked this pull request as draft
July 29, 2026 10:09
L2 Accuracy Results (EP vs CPU)
Threshold: 0.01 | Run: 3449 - Commit: |
MorphiZen EP Performance Results
EPContext Export Performance
EPContext Import Performance
OGA Benchmark Results
OGA Wheel Smoke (Python benchmark_e2e.py)
Run: 3449 - Commit: |
mingyueliuh
force-pushed
the
feat/hipsr-expand-llvm-lowering
branch
2 times, most recently
from
July 31, 2026 02:29
b1c4226 to
f97cff9
Compare
Lower Expand to wrap_expand with AS1 data pointers and AS0 shape metadata for both host shape operands and shape attributes. Co-Authored-By: GPT-5.6 Sol <noreply@openai.com> Made-with: Cursor
Centralize the runtime ABI and argument conversion while preserving explicit host shape metadata. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hipsr.expandto thewrap_expandruntime callshape_attrformsTest plan
hip-mlir-optAI assistance
Cursor assisted with isolating the existing Expand lowering changes, resolving registration conflicts against the latest main branch, and preparing tests and PR text. The changes were reviewed against the generated LLVM IR and validated by rebuilding
hip-mlir-optand running the complete LIT suite.