set dependency range for ROCm components#1192
Open
frepaul wants to merge 4 commits into
Open
Conversation
RVS is expected to work with any version of ROCm that has same major number version.Hence setting the version depenency to the range of versions.
Setting version upper bound will restrict upgrade of ROCm stack if RVS build for ROCm 7 series is already installed on the system. With ROCm upgraded to higher major version assuming all libraries that RVS depend on remain same major version RVS should continue to work. If major version of any of the dependency change rvs will fail at the dependency load time.
package name for ROCm runtime,comgr,hip is amdrocm-runtime.
Sync-up with master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
RVS is expected to work with any version of ROCm that has same major number version. Hence setting the version dependency to the range of versions.
Test Plan
Check dependency field once pkg is created.
Test Result
NA