Skip to content

Ensure shadow async re-raises CancelledError after cleanup#1785

Merged
RNA4219 merged 1 commit into
mainfrom
codex/reraise-asyncio.cancellederror-after-cleanup
Oct 30, 2025
Merged

Ensure shadow async re-raises CancelledError after cleanup#1785
RNA4219 merged 1 commit into
mainfrom
codex/reraise-asyncio.cancellederror-after-cleanup

Conversation

@RNA4219

@RNA4219 RNA4219 commented Oct 30, 2025

Copy link
Copy Markdown
Owner

Summary

  • ensure the shadow async worker always re-raises asyncio.CancelledError after running cleanup
  • finalize shadow metrics within a finally block so cleanup executes before propagation
  • add regression coverage for cancellation to confirm metrics finalization occurs

Testing

  • pytest projects/04-llm-adapter-shadow/tests/test_shadow_async.py

https://chatgpt.com/codex/tasks/task_e_6902aa251a7c832180df11b0a626afdd

@RNA4219
RNA4219 merged commit 8ab1385 into main Oct 30, 2025
5 checks passed
@RNA4219
RNA4219 deleted the codex/reraise-asyncio.cancellederror-after-cleanup branch October 30, 2025 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant