Skip to content

Cleanup from code review on 134#139

Open
AlexAxthelm wants to merge 1 commit into
mainfrom
observability-cleanup
Open

Cleanup from code review on 134#139
AlexAxthelm wants to merge 1 commit into
mainfrom
observability-cleanup

Conversation

@AlexAxthelm

Copy link
Copy Markdown
Collaborator
  • Document statement truncation
  • document clearer make startup

* Document statement truncation
* document clearer `make` startup

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates local developer documentation and in-code comments to clarify how query statements are normalized/truncated in the observability tooling, and to make make-based startup instructions more explicit.

Changes:

  • Clarify that SQL statements are normalized and truncated (2000 char prefix) and how that affects query grouping in analysis output.
  • Add an in-code note explaining the truncation tradeoff and pointing readers to the performance doc.
  • Adjust docker-compose local comment to reference the make reboot-docker target explicitly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
docker-compose.local.yml Clarifies make startup command references in compose comments.
deployments/PERFORMANCE.md Documents statement truncation behavior in query analysis output.
deployments/api/src/stitch/api/observability/query_timing.py Adds explanatory comment about normalization/truncation and its impact on grouping.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread deployments/PERFORMANCE.md
@github-actions

Copy link
Copy Markdown

CD summary 5f677d2

Frontend: https://witty-mushroom-017a3dc1e-139.westus2.1.azurestaticapps.net

Deployments (4)
service url fqdn
api open pr-139-api.purplegrass-c07d0a94.westus2.azurecontainerapps.io
entity-linkage open pr-139-entity-linkage.purplegrass-c07d0a94.westus2.azurecontainerapps.io
frontend https://witty-mushroom-017a3dc1e-139.westus2.1.azurestaticapps.net
stitch-llm open pr-139-stitch-llm.purplegrass-c07d0a94.westus2.azurecontainerapps.io
Database (1)
db_name postgres_host postgres_port postgres_db
pr_139 stitch-dev.postgres.database.azure.com 5432 pr_139
Jobs (2)
job image postgres_db api_url auth_mode
db-migrations ghcr.io/rmi/stitch-api:pr-139@sha256:e8bcff09174fe3b05dafb3792a5a8b18a69ef0b23b762c027d7e1bde4476dd19 pr_139
seed ghcr.io/rmi/stitch-seed:pr-139@sha256:e013ea45f00406cb71a939cfc74958ab4dad05fe1c404967e5fd247d472299fb https://pr-139-api.purplegrass-c07d0a94.westus2.azurecontainerapps.io/api/v1 stitch-client-bearer-token
Images (4)
build_time commit_time git_sha image image_digest
2026-06-18T14:33:45Z 2026-06-18T14:33:24Z 9a2c299 ghcr.io/rmi/stitch-api:pr-139 ghcr.io/rmi/stitch-api:pr-139@sha256:e8bcff09174fe3b05dafb3792a5a8b18a69ef0b23b762c027d7e1bde4476dd19
2026-06-18T14:33:46Z 2026-06-18T14:33:24Z 9a2c299 ghcr.io/rmi/stitch-entity-linkage:pr-139 ghcr.io/rmi/stitch-entity-linkage:pr-139@sha256:1f6a2edc84aedb96b015f5be7cbdbf9fc18af0e68864d7d18349f88e2255b6c5
2026-06-18T14:33:47Z 2026-06-18T14:33:24Z 9a2c299 ghcr.io/rmi/stitch-seed:pr-139 ghcr.io/rmi/stitch-seed:pr-139@sha256:e013ea45f00406cb71a939cfc74958ab4dad05fe1c404967e5fd247d472299fb
2026-06-18T14:33:49Z 2026-06-18T14:33:24Z 9a2c299 ghcr.io/rmi/stitch-stitch-llm:pr-139 ghcr.io/rmi/stitch-stitch-llm:pr-139@sha256:ae3752e0451341d5bc0359b554f37a76214532fa552ba837294347528eb48bce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants