Skip to content

.github/workflows: Only run tool buildtests in merge queue - #22701

Open
AnnsAnns wants to merge 1 commit into
RIOT-OS:masterfrom
AnnsAnns:build-test-in-merge
Open

AnnsAnns wants to merge 1 commit into
RIOT-OS:masterfrom
AnnsAnns:build-test-in-merge

Conversation

@AnnsAnns

@AnnsAnns AnnsAnns commented Sep 14, 2026

Copy link
Copy Markdown
Member

Contribution description

The build tests are taking a lot of CI time (also spam the CI status page) while I couldnt find a single instance where they actually failed, mostly because these tools are rarely ever touched. I tried properly filtering them to only trigger when something changes but the current design of these tests didn't make that trivial + it required changes to our current merge rules on github. This is a (hopefully working) compromise for now where this only gets triggered in the merge queue which should at least stop it from instantly doing stuff as soon as a PR gets opened which is a complete waste.

Testing procedure

idk, push, yolo

Issues/PRs references

Kinda relates to #22679 but mostly in a procrastination kind of way I guess

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • I looked for solutions with DeepSeek v4.1 Flash but even the LLM couldn't help me find a good solution :(

@AnnsAnns AnnsAnns added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR AI: Not Used AI was stated to not be used in this PR/Issue labels Sep 14, 2026
@github-actions github-actions Bot added the Area: CI Area: Continuous Integration of RIOT components label Sep 14, 2026
@AnnsAnns
AnnsAnns requested a review from crasbe September 14, 2026 15:36
@AnnsAnns AnnsAnns added the AI: Ducky PR/Issue uses AI for asking questions, AI was not involved in final product. label Sep 14, 2026
@riot-ci

riot-ci commented Sep 14, 2026

Copy link
Copy Markdown

Murdock results

✔️ PASSED

4201227 .github/workflows: Only run buildtests in merge queue

Success Failures Total Runtime
1 0 1 02m:29s

Artifacts

@AnnsAnns

Copy link
Copy Markdown
Member Author

Ah these are pre-requirements to even get into the merge queue? :/

@crasbe crasbe added the Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation label Sep 14, 2026
@crasbe

crasbe commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Ah these are pre-requirements to even get into the merge queue? :/

That setting can be changed by an admin. Although you could modify the tools-build-success test to return success if the other tests were skipped due to the files not being changed.

Not sure what to do about the python-tests and whether or not that is also part of the tools-build-success consideration (i.e. the explicit requirement could be lifted for it).

@Teufelchen1 Teufelchen1 changed the title .github/workflows: Only run buildtests in merge queue .github/workflows: Only run tool buildtests in merge queue Sep 17, 2026

jobs:
python-tests:
if: github.event_name != 'merge_group'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does merging of a merge group count as push to the master branch? 🤔 The github docs confuse me.

@Teufelchen1

Copy link
Copy Markdown
Contributor

The build tests are taking a lot of CI time [..]

Do they? What do you consider "a lot of CI time"?

@crasbe

crasbe commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

The build tests are taking a lot of CI time [..]

Do they? What do you consider "a lot of CI time"?

image

The tools-buildtest workflow is the one that takes the most amount of time. I'm not sure if they also run on Murdock though?

@Teufelchen1

Copy link
Copy Markdown
Contributor

I was looking for that statistic for 10 min and couldn't find it. Concluding I had misremembered. But of course it is under insight and not under actions or in the settings. 🫠

@Teufelchen1

Copy link
Copy Markdown
Contributor

Okay, I agree it is using a lot of CI.
Also, shouldn't we run those kind of tests in murdock? Just to be less dependable on github.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: Ducky PR/Issue uses AI for asking questions, AI was not involved in final product. AI: Not Used AI was stated to not be used in this PR/Issue Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants