Skip to content

tests/sys/shell: escape backslash in test input - #22439

Open
Old-Ding wants to merge 1 commit into
RIOT-OS:masterfrom
Old-Ding:codex/shell-test-escape-warning
Open

tests/sys/shell: escape backslash in test input#22439
Old-Ding wants to merge 1 commit into
RIOT-OS:masterfrom
Old-Ding:codex/shell-test-escape-warning

Conversation

@Old-Ding

@Old-Ding Old-Ding commented Jul 5, 2026

Copy link
Copy Markdown

Summary

  • escape the backslash in the shell escaping test input so Python no longer treats \ as an invalid escape sequence
  • remove the now-unneeded # noqa: W605 suppression

Verification

  • python compile check with SyntaxWarning captured for tests/sys/shell/tests/01-run.py reports TOTAL 0
  • git diff --check
  • git ls-files --eol tests/sys/shell/tests/01-run.py

I also checked for open duplicate PRs/issues mentioning invalid escape, W605, and this test file, and found no matches.

I did not run the full shell test because it depends on a RIOT board/terminal test environment that is not available locally.

Declaration of AI-Tools / LLMs usage:

AI-Tools / LLMs that were used are:

  • OpenAI Codex for code generation and local static review, with user-directed agent workflow.

Python 3.14 warns about the literal backslash-space sequence in the shell escaping test input. Escape the backslash in the Python string so the generated command stays unchanged without relying on an invalid escape sequence.

Generated-by: OpenAI Codex
Signed-off-by: aineoae86-sys <ai.neo.ae86@gmail.com>
@github-actions

github-actions Bot commented Jul 5, 2026

Copy link
Copy Markdown

Hey @Old-Ding, thank you for your first contribution! We really appreciate it! If you haven't already, please take a look at our contributing guidelines before the review process starts. Also, due to how the GitHub review system works, please avoid force-pushing or squashing your commits unless asked to by a maintainer (or unless your commit is still in "draft commit" stage). Lastly, make sure to comply with our AI Policy when using AI. Your pull request will be reviewed as soon as possible.

@github-actions github-actions Bot added the Area: tests Area: tests and testing framework label Jul 5, 2026
@AnnsAnns AnnsAnns added the AI: Vibed PR/Issue appears to be more AI than Human. label Jul 6, 2026
@AnnsAnns

AnnsAnns commented Jul 6, 2026

Copy link
Copy Markdown
Member

Before we go any further, I want to strongly emphasize just how important it is to get a proper, working development environment set up — this really is the foundation upon which everything else depends. That said, I'd also love to learn more about the backstory here — specifically, how did you first stumble upon this issue? Was this something that came up organically while you were actively using this module for a particular purpose or use case? Any detail you can share, however small it may seem, would be genuinely useful. On top of that, whenever you get the chance, would you be able to send over a photo showing your test setup in its current state — and, alongside that, paste in the complete, word-for-word log output from your test run? Having both the visual and the raw text will make it far easier to fully understand — and ultimately resolve — the situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AI: Vibed PR/Issue appears to be more AI than Human. Area: tests Area: tests and testing framework

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants