Convert Define into an enum #3276
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Convert
Definedinto an enum. The justification of this is PEP 484, which suggests that singletons should be represented as enums with a single element. The reason why this matters is because it lets you sayif x is not UNDEFand the type checker will correctly narrow the type to be no longerDefined, because all enum variants have been excluded.Checklist
the same change.
./examples.so maintainers can fix minor issues and keep your PR up to date.