BinderHub機能のテストにおける停止中のBinderHubの設定を修正#26
Closed
chiku-samugari wants to merge 1 commit intoRCOSDP:mainfrom
Closed
Conversation
chiku-samugari
force-pushed
the
feature/augument-dummy-binderhub-config
branch
from
541759a to
c468cca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
RDM-ember-osf-webの解析機能に関するバグ修正PRにより、解析機能におけるBinderHub/JupyterHubのヘルスチェックはOAuthの認証用のURLが設定されている場合にのみ実行されるように修正された。本PRはこれに追従し、「OAuth連携する、現在稼働していないBinderHub」の例として用いるエントリに、認証用のURLが設定されるための修正を行なう。
Changes
テスト手順-BinderHub-BinderHubアドオン-停止中のBinderHubアドオン.ipynbで、停止中のBinderHubとして指定するエントリにclient idやsecretを入力するように変更することで、認証用のURLが設定されるように修正した。Custom Test Configurationに
EMBER_IMAGEとして指定したchiku314/rdm-ember-osf-web:hotfix-gate-healthcheckは冒頭に述べたバグ修正を適用して作成したイメージである。Ticket
n/a
Custom Test Configuration