Open
Conversation
yacchin1205
reviewed
Nov 7, 2023
shun-nakazawa
commented
Dec 19, 2024
There was a problem hiding this comment.
Pull Request Overview
This PR prefixes Mako template filenames with the addon name to avoid caching collisions across different addons.
- Renamed template includes in user and node settings to
myminio_* - Updated
node_settings_templateanduser_settings_templatepaths inapps.py - Adjusted README examples to document the new
<アドオン名>_*filename convention
Reviewed Changes
Copilot reviewed 8 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| StorageAddon/osf.io/addon/templates/*.mako | Include calls updated to use myminio_* filenames |
| StorageAddon/osf.io/addon/apps.py | Template path variables updated to myminio_* files |
| StorageAddon/README.md | Documentation updated to show <アドオン名>_* naming |
| Skelton/addon/apps.py | node_settings_template updated to myskelton_* |
| Skelton/README.md | Template name placeholder and links updated |
| ScreenExpansion/osf.io/addon/apps.py | node_settings_template updated to myscreen_* |
| ScreenExpansion/README.md | Template name placeholder updated |
Comments suppressed due to low confidence (3)
ScreenExpansion/README.md:51
- [nitpick] The example uses a placeholder
<アドオン名>_node_settings.makobut the actual link below points tomyscreen_node_settings.mako. You may want to clarify this placeholder or replace it with the real filename to avoid confusion.
│ └── <アドオン名>_node_settings.mako ... Node設定パネル
StorageAddon/osf.io/addon/templates/myminio_user_settings.mako:6
- This include references a new template file
myminio_credentials_modal.mako. Ensure that the file has been created or renamed in the templates directory; otherwise this include will fail at runtime.
<%include file="myminio_credentials_modal.mako"/>
Skelton/addon/apps.py:38
- [nitpick] Consider adding or updating a corresponding
user_settings_templateentry to match the new naming convention, ensuring consistency with other addons that define both user and node templates.
node_settings_template = os.path.join(TEMPLATE_PATH, 'myskelton_node_settings.mako')
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
表題の通りです。
Ticket
GRDM-37474