Players and misc. stuff #114
Conversation
|
|
||
| public: | ||
| static Context& current(); | ||
| static __declspec(noinline) bool isInRole(Identities identity, Permissions permission); |
There was a problem hiding this comment.
Why is this noinline?
It won't inline regardless, since its defined in a C++ file.
There was a problem hiding this comment.
SecurityContext::requirePermission does not inline this function in RBXGS although it was inlined for me when I was matching this function.
Functions defined in the source file can STILL be inlined, see BlockBlockContact::computeIsColliding overloads
There was a problem hiding this comment.
SecurityContext::requirePermission does not inline this function in RBXGS although it was inlined for me when I was matching this function.
How? requirePermission is defined in the header, and isInRole is defined in the C++ file. It should not inline.
Functions defined in the source file can STILL be inlined, see BlockBlockContact::computeIsColliding overloads
Shouldn't be possible.
Client/Network/Player.cpp
Outdated
| } | ||
| } | ||
|
|
||
| TimerService* tService = ServiceProvider::create<TimerService>(this); |
There was a problem hiding this comment.
just use its full name
|
|
||
| namespace RBX | ||
| template<class Class> | ||
| class PluginInterfaceAdapter : public PluginInterface |
There was a problem hiding this comment.
Absolutely not. Players.h is in the public includes directory, meaning that App can include this file. App does not have RakNet in its includes directory so this will not work.
| #include "SuperSafeChanged.h" | ||
| #include "v8tree/Service.h" | ||
| #include "v8datamodel/ModelInstance.h" | ||
| #include "Client.h" |
There was a problem hiding this comment.
Not in the public includes directory, so this will not work.
| #include "Network/Player.h" | ||
| #include "Network/SuperSafeChanged.h" | ||
| #include "Player.h" | ||
| #include "Streaming.h" |
There was a problem hiding this comment.
Not in the public includes directory, so this will not work.
| #pragma once | ||
| #include "Network/Player.h" | ||
| #include "Network/SuperSafeChanged.h" | ||
| #include "Player.h" |
|
I moved the declarations and includes noted in the reviews into the source files, should be resolved but check again |
2 participants
No description provided.