Skip to content

Conversation

@AdornedJoker
Copy link

@AdornedJoker AdornedJoker commented Dec 26, 2025

This has almost all the functions except for,
setImageServerViewNoLerp, characterZoom, getNewZoomDistance

@bluepilledgreat
Copy link
Collaborator

I have some files relating to Camera in my branch. This PR will have to wait for a bit, sorry!

@AdornedJoker
Copy link
Author

That's alright! Should I close this PR then?

@bluepilledgreat
Copy link
Collaborator

That's alright! Should I close this PR then?

No, keep it open. Once the camera files are committed into the master branch, you can fix any merge conflicts that arise from it.
So far, this PR looks good.

@bluepilledgreat
Copy link
Collaborator

Can you resolve the merge conflicts?

@AdornedJoker
Copy link
Author

Hang on

AdornedJoker and others added 2 commits December 29, 2025 12:35
I moved G3D. I was having compiler errors when having it in between Instance and Extents.
@AdornedJoker
Copy link
Author

Fixed the merge conflict involving with the header.

@AdornedJoker AdornedJoker marked this pull request as draft January 4, 2026 19:25
@AdornedJoker
Copy link
Author

I got a question. Do I need to do every single function instead of doing some of it?

@AdornedJoker AdornedJoker marked this pull request as ready for review January 4, 2026 20:39
@AdornedJoker
Copy link
Author

I'm going to be honest, this is the best I can do with this. I'm already at my limit.

I'm just unable to do all of it.

@ThePlayerRolo
Copy link
Contributor

I'm going to be honest, this is the best I can do with this. I'm already at my limit.

I'm just unable to do all of it.

i think you should be able to merge without everything. Progress is still progress

@AdornedJoker
Copy link
Author

I hope so!

@AdornedJoker
Copy link
Author

I feel like this needs another review since I added more code. I honestly don't want to add more code into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants