New option: compl_data.max_list_len#587
Merged
Merged
Conversation
PMassicotte
reviewed
Jun 5, 2026
| */ | ||
| SEXP nvimcom_Start(SEXP vrb, SEXP anm, SEXP swd, SEXP imd, SEXP szl, SEXP tml, | ||
| SEXP dbg, SEXP nvv, SEXP rinfo) { | ||
| SEXP nvimcom_Start(SEXP vrb, SEXP anm, SEXP swd, SEXP imd, SEXP lsl, SEXP szl, |
Collaborator
There was a problem hiding this comment.
I think there is an error in the order of the parameters
Should it be:
SEXP nvimcom_Start(SEXP vrb, SEXP anm, SEXP swd, SEXP lsl, SEXP imd, SEXP szl, ...)instead of
SEXP nvimcom_Start(SEXP vrb, SEXP anm, SEXP swd, SEXP imd, SEXP lsl, SEXP szl, ...)
PMassicotte
reviewed
Jun 5, 2026
Collaborator
|
Two small comments, other than that it is perfect, good job! |
Co-authored-by: Philippe Massicotte <pmassicotte@hotmail.com>
Member
Author
|
Thank you for the review, @PMassicotte! I think everything is OK now, and I will merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #586