Skip to content

Conversation

maiieul
Copy link
Member

@maiieul maiieul commented Oct 10, 2025

What is it?

  • Bug

Description

The added logic in manualChunks led to a circular dependency in a qwik-astro app. This was a small optimization and doesn't seem to change anything now that we use the Rollup.onlyExplicitManualChunks fix.

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@maiieul maiieul requested a review from a team as a code owner October 10, 2025 10:41
Copy link

changeset-bot bot commented Oct 10, 2025

🦋 Changeset detected

Latest commit: bac1d78

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@builder.io/qwik Patch
eslint-plugin-qwik Patch
@builder.io/qwik-city Patch
@builder.io/qwik-react Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maiieul maiieul self-assigned this Oct 10, 2025
@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Oct 10, 2025
Copy link

pkg-pr-new bot commented Oct 10, 2025

Open in StackBlitz

npm i https://pkg.pr.new/@builder.io/qwik@8052
npm i https://pkg.pr.new/@builder.io/qwik-city@8052
npm i https://pkg.pr.new/eslint-plugin-qwik@8052
npm i https://pkg.pr.new/create-qwik@8052

commit: bac1d78

Copy link
Contributor

github-actions bot commented Oct 10, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview bac1d78

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit f080be0 into QwikDev:main Oct 10, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Oct 10, 2025
Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏 thanks for this @maiieul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants