fix(eslint-plugin): detect node API usage more accurately #7664
+59
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build/v2
🦋 Changeset detectedLatest commit: 9ae3250 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
wmertens
reviewed
Jun 24, 2025
packages/eslint-plugin-qwik/tests/scope-use-task/valid-scope-use-return-object.tsx
Show resolved
Hide resolved
wmertens
changed the title
wmertens
requested changes
Jun 24, 2025
…prove edge case handling
…efault forbidden APIs
wmertens
requested changes
Jul 5, 2025
packages/eslint-plugin-qwik/tests/scope-use-task/invalid-scope-use-function.tsx
Outdated
Show resolved
Hide resolved
packages/eslint-plugin-qwik/tests/scope-use-task/valid-scope-use-return-object.tsx
Show resolved
Hide resolved
wmertens
reviewed
Nov 13, 2025
| // If there are definitions, check if any of them are standard declaration types. | ||
| // This means the identifier refers to a user-declared variable, parameter, function, class, or an import. | ||
| return variable.defs.some((def) => { | ||
| return variable?.defs.some((def) => { |
Member
There was a problem hiding this comment.
this ? is not needed because you return if empty above it, and then the as boolean is'n't needed either
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
I enhanced the
qwik-eslint-pluginto support two edge cases:initin aVariableDeclaratorin AST.2.When path is used as a property key inside an object.
adding two situations
Checklist
pnpm change