-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat(core): Add Amazon Bedrock provider support #809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@anwschne {
"authType": "bedrock",
"model": "qwen.qwen3-coder-30b-a3b-v1:0"
}This is not the same as your configuration example. |
|
Thanks @lucidfrontier45 ! I decided the refactor and remove the short names as it just adds confusion. PR updated |
| }, | ||
| }, | ||
| }, | ||
| } as OpenAI; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, glad we do not use any other api of the OpenAI client.
But this hints to me that maybe we should use a duck type that requires only the APIs we actually use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest that we put all the bedrock-specific provider/converts to /provider/bedrock with a barrel file.
Everything else is fine.
Changes applied, thanks @Mingholy ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
abb0b86 to
30fb0e9
Compare
Implements AWS Bedrock integration for Qwen3-Coder models using the Converse API. - Add BedrockOpenAICompatibleProvider with full OpenAI format conversion - Support AWS credential chain (profiles, env vars, instance roles) - Add comprehensive test coverage (72 tests) - Add docs/cli/bedrock.md documentation - Update model mappings to use actual Bedrock model IDs Fixes QwenLM#759
…k model IDs - Remove BEDROCK_MODEL_MAP and simplify getBedrockModelId() - Update default model to use full Bedrock ID: qwen.qwen3-coder-30b-a3b-v1:0 - Update documentation to list models by region (us-east-1, us-west-2) - Add 480B and 235B models available in us-west-2 - Update all tests to use full Bedrock model IDs - Add note that model shortcuts are not supported
Move all Bedrock-specific provider files into provider/bedrock subdirectory with a barrel export file for better code organization and modularity. - Create provider/bedrock directory structure - Move bedrock.ts → bedrock/provider.ts - Move bedrockTypes.ts → bedrock/types.ts - Move bedrockConverter.ts → bedrock/converter.ts - Move test files to bedrock/ subdirectory - Add barrel file (index.ts) for clean exports - Update all import paths throughout codebase - Apply Prettier formatting to documentation and tests All 2728 tests passing (2703 core + 25 VSCode) ESLint passing with 0 warnings
30fb0e9 to
0fc07b9
Compare
|
Fixed conflicts from recent merges. |
Summary
Implements AWS Bedrock integration for Qwen3-Coder models using the Converse API.
This PR adds native Amazon Bedrock authentication support, allowing users to leverage Qwen models through AWS infrastructure with standard AWS credential chains.
Changes
BedrockOpenAICompatibleProviderwith full OpenAI-to-Bedrock format conversionqwen.qwen3-coder-30b-a3b-v1:0(Qwen3-Coder-30B-A3B-Instruct)qwen.qwen3-32b-v1:0(Qwen3 32B dense model)docs/cli/bedrock.mdTest Plan
Configuration Example
{ "authType": "bedrock", "model": "qwen.qwen3-coder-30b-a3b-v1:0" }export AWS_PROFILE=my-profile
export AWS_REGION=us-east-1
Fixes #759