Skip to content

gas_price() estimate function may not return expected value for multi-native token #848

Open

Description

@qizhou

def gas_price(self, token_id: int) -> Optional[int]:

The current estimation will estimate based on the historical gas price of the same token id, which may be empty or small if the token id is not frequently used. A better way may still estimate the price for QKC first and then convert to the price for token id.

Further, returning MIN_TX_POOL_GAS_PRICE for other token ids other than QKC may be wrong.

Activity

  1. qizhou commented on Mar 20, 2020

    @qizhou
    ContributorAuthor

    We may also need to add a jsonrpc that accepts:

    • chain id
    • token id
    • gas price
      and outputs
    • gas price in QKC
  2. ninjaahhh commented on Mar 23, 2020

    @ninjaahhh
    Contributor

    lower the priority since it's not consensus-critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions