Open
Conversation
blockchaindevsh
requested review from
dajuguan,
ping-ke,
qizhou,
qzhodl and
syntrust
This was referenced Jul 7, 2025
dajuguan
approved these changes
Jul 16, 2025
| EIP1559Denominator uint64 `json:"eip1559Denominator"` | ||
| EIP1559DenominatorCanyon *uint64 `json:"eip1559DenominatorCanyon,omitempty"` | ||
| // The multiplier of the L1BaseFeeScalar, used to keep the L1BaseFeeScalar size compatible with uint32 and calculate the effective L1BaseFeeScalar; | ||
| // Only effective when the value is non-zero |
|
|
||
| costFunc(emptyTx.RollupCostData(), math2.MaxUint64-1 /*math2.MaxUint64 is used as a special mark in NewL1CostFunc, so minus 1*/) | ||
|
|
||
| require.Equal(t, params.L1ScalarMultipliersCalled, true) |
There was a problem hiding this comment.
Why not pass these two parameters directly into conf.Optimism = &OptimismConfig{EIP1559Elasticity: 50, EIP1559Denominator: 10, EIP1559DenominatorCanyon: uint64ptr(250)}, and check whether the return values of costFunc for both params are greater than 0?
That way, we wouldn’t need to stub the L1ScalarMultipliersCalled flag in the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
releasebranch is checked out from the latestoptimismbranch.This PR adds
cgtrelated changes for the initial release.