add explicit cleanup_expired_proposals extrinsic#366
Closed
n13 wants to merge 1 commit intofeat/multisig_hs_v2from
Closed
add explicit cleanup_expired_proposals extrinsic#366n13 wants to merge 1 commit intofeat/multisig_hs_v2from
n13 wants to merge 1 commit intofeat/multisig_hs_v2from
Conversation
Replace automatic expired proposal cleanup with explicit extrinsic. Removes implicit cleanup from propose/approve/cancel to provide predictable gas costs. Wallets now call cleanup_expired_proposals when needed.
Collaborator
Author
|
that was already done with remove_expired |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored expired proposal cleanup in the multisig pallet from automatic (implicit) to explicit (opt-in).
Before:
propose,approve, andcancelextrinsics automatically iterated over proposals to clean up expired ones, adding unpredictable gas costs.After: A new
cleanup_expired_proposalsextrinsic allows wallets to explicitly trigger cleanup when they detect expired proposals.Changes
auto_cleanup_expired_proposalscalls frompropose,approve,cancel. Added newcleanup_expired_proposalsextrinsic (call_index 7).eparameter from existing extrinsics, addedcleanup_expired_proposals(e)function).cleanup_expired_proposalsbenchmark.Benefits