Skip to content

[mix_model]: Fix issues and improve the lecture #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

[mix_model]: Fix issues and improve the lecture #642

wants to merge 12 commits into from

Conversation

@bishmaybarik
Copy link
Member

@bishmaybarik bishmaybarik commented Oct 1, 2025 •
edited
Loading

This PR fixes the following issues:

The issue was the following:

  • style guide review
  • fix full web links that are currently used across the lectures with a range of link text, doc links.

@bishmaybarik bishmaybarik self-assigned this Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (fb4ddb0)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (7cba5eb)

📚 Changed Lecture Pages: mix_model

@bishmaybarik bishmaybarik marked this pull request as ready for review October 1, 2025 10:44
@bishmaybarik bishmaybarik requested a review from mmcky October 1, 2025 10:44
@bishmaybarik
Copy link
Member Author

bishmaybarik commented Oct 1, 2025

hi @mmcky , I have made some changes and made sure I pushed everything to this branch. although I have checked it myself, it'll be nice to have it reviewed by you :-)

if there are further issues with the lecture, please let me know!

@bishmaybarik bishmaybarik added ready and removed in-work labels Oct 1, 2025
@bishmaybarik bishmaybarik changed the title [FIX]: Improve the mix_model.md lecture [mix_model.md]: Fix issues and improve the lecture Oct 1, 2025
@bishmaybarik bishmaybarik changed the title [mix_model.md]: Fix issues and improve the lecture [mix_model]: Fix issues and improve the lecture Oct 1, 2025
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (67c3a4b)

📚 Changed Lecture Pages: mix_model

@bishmaybarik bishmaybarik requested a review from Copilot October 6, 2025 08:36
Copilot AI reviewed Oct 6, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes formatting, style, and link issues in the mix_model lecture to align with style guidelines and improve readability. The changes primarily involve converting raw URLs to proper markdown links, fixing capitalization in headings, and correcting a few punctuation errors.

Key Changes

  • Converted raw web links to proper markdown format with descriptive text
  • Fixed capitalization in section headings to follow consistent style
  • Made minor punctuation and text corrections

@bishmaybarik
Copy link
Member Author

bishmaybarik commented Oct 13, 2025

hi @mmcky, may I know if you have any thoughts on this? I would humbly request you to review this whenever you have the time :-)

HumphreyYang
HumphreyYang reviewed Oct 21, 2025
View reviewed changes
Copy link
Member

@HumphreyYang HumphreyYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks @bishmaybarik! These are great changes!

Noted that if we use

{doc}`lecture_name`

It will give use a hyperlink with the lecture title. So we can reduce the usage of "this lecture" in the lectures.

There are also a few lines of code that's touching 80-character limit so please have a go at breaking them into two lines!

Please let me know what you think.

@HumphreyYang HumphreyYang added review and removed ready labels Oct 21, 2025
@bishmaybarik
Copy link
Member Author

bishmaybarik commented Oct 25, 2025

Thanks for all the suggestions @HumphreyYang -- all of the suggestions are helpful!

I'll make the necessary changes and update this PR as soon as possible.

bishmaybarik and others added 7 commits November 7, 2025 11:13
@bishmaybarik @HumphreyYang
update probability matrix lecture
77881b7 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update to make sentence clearer
5b63456 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update the lecture
76c9249 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update Humphrey's suggestions
aabecbc 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update Humphrey's suggestions
cc3bc96 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update Humphrey's suggestions
11f108d 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update Humphrey's suggestions
92cd96e 
Adding a space between f and the text

Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik @HumphreyYang
update Humphrey's suggestions
d7ed9ce 
This might be out of the scope of this PR but we should only use bold for definitions

Co-authored-by: Humphrey Yang <[email protected]>
@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (77881b7)

📚 Changed Lecture Pages: mix_model

@bishmaybarik @HumphreyYang
update Humphrey's suggestions
4b926c0 
Co-authored-by: Humphrey Yang <[email protected]>
@bishmaybarik
Copy link
Member Author

bishmaybarik commented Nov 7, 2025

thanks again for these great suggestions @HumphreyYang. All the changes have been made -- it would be great if you could have a look at it whenever you have time :-)

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (5b63456)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (76c9249)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (aabecbc)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (cc3bc96)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (11f108d)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (92cd96e)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (4b926c0)

📚 Changed Lecture Pages: mix_model

@github-actions
Copy link

github-actions bot commented Nov 7, 2025

📖 Netlify Preview Ready!

Preview URL: https://pr-642--sunny-cactus-210e3e.netlify.app (d7ed9ce)

📚 Changed Lecture Pages: mix_model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@mmcky mmcky Awaiting requested review from mmcky

@HumphreyYang HumphreyYang Awaiting requested review from HumphreyYang

Assignees

@bishmaybarik bishmaybarik

Labels

improve review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[mix_model] FIX: links are full web links across the lecture

3 participants

@bishmaybarik @HumphreyYang