Skip to content

Task_1_2_1#5

Open
Qangan wants to merge 8 commits into
masterfrom
task-1-2-1
Open

Task_1_2_1#5
Qangan wants to merge 8 commits into
masterfrom
task-1-2-1

Conversation

@Qangan
Copy link
Copy Markdown
Owner

@Qangan Qangan commented Oct 14, 2025

Сделал интерфейс графа и его реализацию с матрицей смежности, без тестов и доков

@github-actions
Copy link
Copy Markdown

File Coverage [0%]
AdjMatrixGraph.java 0%
Graph.java 0%
Total Project Coverage 0%

@github-actions
Copy link
Copy Markdown

File Coverage [78.9%]
AdjMatrixGraph.java 96.13% 🍏
AdjListGraph.java 95.54% 🍏
IncMatrixGraph.java 81.63% 🍏
Graph.java 0%
Total Project Coverage 78.9%

@github-actions
Copy link
Copy Markdown

File Coverage [84.36%] 🍏
AdjMatrixGraph.java 96.13% 🍏
AdjListGraph.java 95.54% 🍏
IncMatrixGraph.java 81.63% 🍏
Main.java 0%
Total Project Coverage 84.36% 🍏

@Qangan
Copy link
Copy Markdown
Owner Author

Qangan commented Oct 22, 2025

Я забыл добавить вас в качестве ревьювера к моменту мягкого дедлайна, извините

Copy link
Copy Markdown
Collaborator

@Sharapov-Maksim Sharapov-Maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Также исправьте замечания checkstyle

Comment thread Task_1_2_1/app/src/main/java/qangan/graph/Graph.java
Comment thread Task_1_2_1/app/build.gradle.kts
Comment on lines +11 to +12
/** Graph interface. */
interface Graph {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Какой модификатор доступа используется в Java по умолчанию?

Сделайте интерфейс public

Comment thread Task_1_2_1/app/src/main/java/qangan/graph/AdjListGraph.java Outdated
Comment thread Task_1_2_1/app/src/main/java/qangan/graph/AdjListGraph.java Outdated
Comment thread Task_1_2_1/app/src/main/java/qangan/graph/AdjListGraph.java
Comment thread Task_1_2_1/app/src/main/java/qangan/graph/AdjListGraph.java
Comment thread Task_1_2_1/app/src/main/java/qangan/graph/Graph.java Outdated
Comment thread Task_1_2_1/app/src/main/java/qangan/graph/AdjMatrixGraph.java Outdated
@github-actions
Copy link
Copy Markdown

File Coverage [89.45%] 🍏
AdjMatrixGraph.java 95.02% 🍏
IncMatrixGraph.java 93.5% 🍏
AdjListGraph.java 93.13% 🍏
Main.java 0%
Total Project Coverage 89.45% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [89.45%] 🍏
AdjMatrixGraph.java 95.02% 🍏
IncMatrixGraph.java 93.5% 🍏
AdjListGraph.java 93.13% 🍏
Main.java 0%
Total Project Coverage 89.45% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [81.95%] 🍏
AdjMatrixGraph.java 95.02% 🍏
IncMatrixGraph.java 93.5% 🍏
AdjListGraph.java 93.13% 🍏
Graph.java 28.63%
Main.java 0%
Total Project Coverage 81.95% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [82.34%] 🍏
AdjMatrixGraph.java 95.02% 🍏
IncMatrixGraph.java 94.02% 🍏
AdjListGraph.java 93.32% 🍏
Graph.java 28.63%
Main.java 0%
Total Project Coverage 82.34% 🍏

@github-actions
Copy link
Copy Markdown

File Coverage [90.64%] 🍏
Graph.java 96.92% 🍏
AdjMatrixGraph.java 95.02% 🍏
IncMatrixGraph.java 94.02% 🍏
AdjListGraph.java 93.32% 🍏
Main.java 0%
Total Project Coverage 90.64% 🍏

@Qangan
Copy link
Copy Markdown
Owner Author

Qangan commented Oct 24, 2025

Понял почему у меня 0% на интерфейсе было, я топсорт забыл протестировать

@Sharapov-Maksim
Copy link
Copy Markdown
Collaborator

Не забудьте запросить ревью, когда будете готовы

Copy link
Copy Markdown
Collaborator

@Sharapov-Maksim Sharapov-Maksim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Задание зачтено, PR можно мёржить

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants