Skip to content

add notebook number to list of exercises to check #371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add notebook number to list of exercises to check #371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lms/templates/status.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ <h1>{{ _('Exercises operations room') }}</h1>
<tr>
<th scope="col">#</th>
<th scope="col">{{ _('Name') }}</th>
<th scope="col">{{ _('Notebook') }}</th>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should check if any of the exercises has notebook before showing this column

<th scope="col">{{ _('Checked') }}</th>
<th scope="col">{{ _('Solved') }}</th>
<th scope="col">{{ _('Percentage') }}</th>
Expand All @@ -21,6 +22,9 @@ <h1>{{ _('Exercises operations room') }}</h1>
<tr>
<th scope="row">{{ exercise['id'] }}</th>
<td><a href="/check/{{ exercise['id'] }}">{{ exercise['name'] | e }}</a></td>
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}
Comment on lines +25 to +27
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alignment:

Suggested change
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}

<td>{{ exercise['checked'] }}</td>
<td>{{ exercise['submitted'] }}</td>
<td>{{ (exercise['checked'] * 100 / exercise['submitted']) | round(2, 'floor') }}%</td>
Expand All @@ -34,6 +38,9 @@ <h1>{{ _('Exercises operations room') }}</h1>
<tr>
<th scope="row">{{ exercise['id'] }}</th>
<td><a href="/check/{{ exercise['id'] }}">{{ exercise['name'] | e }}</a></td>
{%- if exercise['notebook'] %}
<td>{{ exercise['notebook'] }}</td>
{%- endif %}
<td>{{ exercise['checked'] }}</td>
<td>{{ exercise['submitted'] }}</td>
<td>{{ (exercise['checked'] * 100 / exercise['submitted']) | round(2, 'floor') }}%</td>
Expand Down