Skip to content

fix: 🐛 Use .parent when disabling items on timeout for private channel messages #3016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Paillat-dev wants to merge 2 commits into
base: master
Choose a base branch
from
+8 −1
Open

fix: 🐛 Use .parent when disabling items on timeout for private channel messages #3016

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2b4ccc7
:bug: Use `.parent` when disabling items on timeout for private chann…
Paillat-dev Dec 2, 2025
7074b88
:memo: CHANGELOG.md
Paillat-dev Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ These changes are available on the `master` branch, but have not yet been releas

- Fixed breaking change in `ui.Select` Generic typing by adding default values to
TypeVars. ([#3002](https://github.com/Pycord-Development/pycord/pull/3002))
- Fixed `View`'s `disable_on_timeout` not working in private (DM) channels.
([#3016](https://github.com/Pycord-Development/pycord/pull/3016))

### Deprecated

Expand Down
7 changes: 6 additions & 1 deletion discord/ui/view.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@
from ..components import TextDisplay as TextDisplayComponent
from ..components import Thumbnail as ThumbnailComponent
from ..components import _component_factory
from ..enums import ChannelType
from ..utils import find
from .core import ItemInterface
from .item import ItemCallbackType, ViewItem
Expand Down Expand Up @@ -303,7 +304,11 @@ async def on_timeout(self) -> None:
if self.disable_on_timeout:
self.disable_all_items()

if not self._message or self._message.flags.ephemeral:
if (
not self._message
or self._message.flags.ephemeral
or (self._message.channel.type == ChannelType.private)
):
message = self.parent
else:
message = self.message
Expand Down