feat: Add support for editing application info and new fields #2994

Lumabots · 2025-11-07T15:17:09Z

Introduces the AppInfo.edit coroutine to allow editing application settings. Updates AppInfo and related types to support new fields such as bot, flags, event webhooks, integration_types_config, and approximate_user_authorization_count. Also refactors type hints and improves handling of optional fields for better API compatibility.

Summary

Information

This PR fixes an issue.
This PR adds something new (e.g. new method or parameters).
This PR is a breaking change (e.g. methods or parameters removed/renamed).
This PR is not a code change (e.g. documentation, README, typehinting,
examples, ...).

Checklist

I have searched the open pull requests for duplicates.
If code changes were made then they have been tested.
- I have updated the documentation to reflect the changes.
If type: ignore comments were used, a comment is also left explaining why.
I have updated the changelog to include these changes.

Introduces the AppInfo.edit coroutine to allow editing application settings. Updates AppInfo and related types to support new fields such as bot, flags, event webhooks, integration_types_config, and approximate_user_authorization_count. Also refactors type hints and improves handling of optional fields for better API compatibility.

pycord-app · 2025-11-07T15:17:13Z

Thanks for opening this pull request!
Please make sure you have read the Contributing Guidelines and Code of Conduct.

This pull request can be checked-out with:

git fetch origin pull/2994/head:pr-2994
git checkout pr-2994

This pull request can be installed with:

pip install git+https://github.com/Pycord-Development/pycord@refs/pull/2994/head

Soheab

Also missing docs for the new attributes.

discord/appinfo.py

Introduces the AppInfo.edit() method to allow editing application settings, including new and previously missing fields such as icon, cover_image, tags, install_params, integration_types_config, flags, event_webhooks_url, event_webhooks_status, and event_webhooks_types. Also adds related helper classes and properties for handling these fields and updates the CHANGELOG accordingly.

Copilot

Pull Request Overview

This pull request adds an AppInfo.edit() method for editing application settings and includes missing fields from the Discord API to the AppInfo class.

Key Changes:

Added AppInfo.edit() method to modify application settings via the Discord API
Added new fields to AppInfo including bot, event_webhooks_*, integration_types_config, and approximate_user_authorization_count
Restructured TypedDict definitions in discord/types/appinfo.py to better reflect the Discord API structure
Added IntegrationTypesConfig helper class for per-installation context configuration

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
discord/types/appinfo.py	Restructured TypedDict definitions, changed from `User` to `PartialUser`, moved many fields to `NotRequired`, and added new type aliases for application integration types
discord/http.py	Added `edit_current_application()` HTTP method to support the new edit functionality
discord/client.py	Removed workaround for missing `rpc_origins` field and cleaned up unused imports
discord/appinfo.py	Added new `edit()` method, new fields and properties, `IntegrationTypesConfig` class, and `to_payload()` method for `AppInstallParams`
CHANGELOG.md	Documented the new feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

discord/appinfo.py

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Updated the AppInfo class to only accept bytes or None for the icon and cover_image parameters, removing support for str. This change clarifies the expected types and may prevent type-related errors.

…encing

…lify owner assignment

Lumabots · 2025-11-25T07:49:48Z

could we some review here ?

discord/appinfo.py

…atus and add setter for event_webhooks_enabled

…iated docstring

discord/http.py

discord/appinfo.py

CHANGELOG.md

discord/appinfo.py

Co-authored-by: Paillat <[email protected]> Signed-off-by: Lumouille <[email protected]>

Lumabots · 2025-11-29T06:33:52Z

Im not home until Tuesday so feel free to edit it

Paillat-dev · 2025-11-29T13:03:37Z

No stress, this one is not urgent

Paillat-dev · 2025-12-04T13:58:35Z

discord/appinfo.py

+        return raw.get(skey)
+
+    @staticmethod
+    def _decode_ctx(value: dict | None) -> AppInstallParams | None:


Suggested change

def _decode_ctx(value: dict | None) -> AppInstallParams | None:

def _decode_ctx(value: dict[Any, Any] | None) -> AppInstallParams | None:

Or other relevant typing, I don't have the context to know here

Paillat-dev · 2025-12-04T13:59:55Z

discord/appinfo.py

+        self.user = user
+
+    @staticmethod
+    def _get_ctx(raw: dict | None, key: int):


Idem as below, we should generally avoid bare dicts in types going forward, at least type them and if it makes sense use a TypedDict from discord.types

yep, i forgot those 2 as they were before inside another function...

Paillat-dev · 2025-12-04T14:00:14Z

discord/appinfo.py

+            return None
+        return {"oauth2_install_params": value._to_payload()}
+
+    def _to_payload(self) -> dict[int, dict[str, object] | None]:


Suggested change

def _to_payload(self) -> dict[int, dict[str, object] | None]:

def _to_payload(self) -> dict[int, dict[str, Any] | None]:

Paillat-dev · 2025-12-04T14:00:46Z

discord/appinfo.py

+        return {"oauth2_install_params": value._to_payload()}
+
+    def _to_payload(self) -> dict[int, dict[str, object] | None]:
+        payload: dict[int, dict[str, object] | None] = {}


Suggested change

payload: dict[int, dict[str, object] | None] = {}

payload: dict[int, dict[str, Any] | None] = {}

I'm curious, why did you go with object instead of Any ? Maybe I'm missing something.

i dont fully remember, but i was basically trying to avoid Any, and object seems like a good feat as its a bit less opaque than Any.
We can revert it to only Any tho

I think we should use Any for consistency, it also is more correct from a typing perspective, see:

https://basedpyright.com/?typeCheckingMode=all&reportAny=false&reportExplicitAny=false&code=GYJw9gtgBALgngBwJYDsDmUkQWEMoCCKcAUCQCYCmwUwArigMYAUAhgFyHEA0UARpzB8AVpUYwAlFAC0APigA5MCkrsSUDVAQhUMNgG0ARAEdThgLoT1m7buZ8jp4xatA

Albeit ideally we should just avoid Any as much as we can.

Paillat-dev · 2025-12-04T14:01:03Z

discord/appinfo.py

+
+    def _encode_install_params(
+        self, value: AppInstallParams | None
+    ) -> dict[str, object] | None:


Suggested change

) -> dict[str, object] | None:

) -> dict[str, Any] | None:

Paillat-dev · 2025-12-04T14:03:36Z

discord/appinfo.py

        self.scopes: list[str] = data.get("scopes", [])
        self.permissions: Permissions = Permissions(int(data["permissions"]))
+
+    def _to_payload(self) -> dict[str, object]:


Suggested change

def _to_payload(self) -> dict[str, object]:

def _to_payload(self) -> dict[str, Any]:

Paillat-dev · 2025-12-04T14:15:19Z

discord/appinfo.py

            "role_connections_verification_url"
        )
+        self.event_webhooks_url: str | None = data.get("event_webhooks_url")
+        self._event_webhooks_status: int | None = data.get("event_webhooks_status")


self._event_webhooks_status supposedly can't be None.

https://discord.mintlify.app/developers/docs/resources/application#application-object

Also, actually this should probably not be private. I think me or someone said the opposite before, I personally incorrectly assumed that it could have just two enum states (1, 2), but since it has 1, 2, 3, we might want to let the user know which one it is if they want. Keep the convenience method tho.

it seems to be able to be None

Yup... seems like: discord/discord-api-docs#8015

I saw that you use try_enum now, but by doing that you access the dict property twice.
Maybe something like this could work ?

event_webhooks_status = data.get("event_webhooks_status") self.event_webhooks_status: ApplicationEventWebhookStatus | None = try_enum(ApplicationEventWebhookStatus, event_webhooks_status) if event_webhooks_status else None

…e it

Lumabots requested a review from a team as a code owner November 7, 2025 15:17

pullapprove4 bot requested a review from Paillat-dev November 7, 2025 15:17

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Nov 7, 2025

style(pre-commit): auto fixes from pre-commit.com hooks

2f54fe7

Lumabots changed the title ~~Add support for editing application info and new fields~~ feat: Add support for editing application info and new fields Nov 7, 2025

Paillat-dev added hold: changelog This pull request is missing a changelog entry hold: testing This pull request requires further testing priority: low Low Priority labels Nov 7, 2025

Soheab reviewed Nov 7, 2025

View reviewed changes

discord/appinfo.py Show resolved Hide resolved

discord/appinfo.py Outdated Show resolved Hide resolved

Lumabots requested review from a team as code owners November 7, 2025 18:00

Lumabots requested review from DA-344, Icebluewolf and Lulalaby November 7, 2025 18:00

style(pre-commit): auto fixes from pre-commit.com hooks

bfa2940

Lumabots requested a review from Copilot November 7, 2025 18:01

Copilot AI reviewed Nov 7, 2025

View reviewed changes

Lumabots and others added 9 commits November 7, 2025 19:08

Update discord/appinfo.py

9893239

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Update discord/appinfo.py

884cd6c

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Update discord/appinfo.py

41f12a2

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Update discord/appinfo.py

714c68a

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Update discord/appinfo.py

734b5ce

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Update discord/appinfo.py

49c90b9

Co-authored-by: Copilot <[email protected]> Signed-off-by: Lumouille <[email protected]>

Restrict icon and cover_image types to bytes or None

76eb883

Updated the AppInfo class to only accept bytes or None for the icon and cover_image parameters, removing support for str. This change clarifies the expected types and may prevent type-related errors.

style(pre-commit): auto fixes from pre-commit.com hooks

bd91789

feat(emoji): add mention property to BaseEmoji for easier emoji refer…

7e5ff54

…encing

Lumabots and others added 2 commits November 11, 2025 17:57

refactor(AppInfo): improve integration_types_config handling and simp…

89d3011

…lify owner assignment

style(pre-commit): auto fixes from pre-commit.com hooks

dfb7907

Lumabots requested a review from Soheab November 11, 2025 15:59

pullapprove4 bot added the PA: All Contributors pending label Nov 11, 2025

Lumabots and others added 3 commits November 14, 2025 12:22

refactor(AppInfo): remove deprecated flags attribute from AppInfo class

9eecbfa

Merge branch 'master' into appinf

ab000ac

Merge branch 'master' into appinf

8c0dcd7

JustaSqu1d reviewed Nov 25, 2025

View reviewed changes

discord/appinfo.py Outdated Show resolved Hide resolved

Lumabots added 2 commits November 25, 2025 11:06

refactor(AppInfo): rename event_webhooks_status to _event_webhooks_st…

03a46e8

…atus and add setter for event_webhooks_enabled

refactor(AppInfo): remove setter for event_webhooks_enabled and assoc…

0b603f5

…iated docstring

Lumabots requested a review from JustaSqu1d November 25, 2025 10:19

Paillat-dev reviewed Nov 27, 2025

View reviewed changes

discord/http.py Outdated Show resolved Hide resolved

Paillat-dev requested changes Nov 27, 2025

View reviewed changes

discord/appinfo.py Outdated Show resolved Hide resolved

discord/appinfo.py Outdated Show resolved Hide resolved

discord/appinfo.py Outdated Show resolved Hide resolved

CHANGELOG.md Outdated Show resolved Hide resolved

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Nov 27, 2025

Paillat-dev reviewed Nov 27, 2025

View reviewed changes

discord/appinfo.py Outdated Show resolved Hide resolved

Update CHANGELOG.md

3c398cc

Co-authored-by: Paillat <[email protected]> Signed-off-by: Lumouille <[email protected]>

refactor: update method names and types in AppInfo and HTTPClient

1b0017c

Lumabots requested a review from Paillat-dev December 2, 2025 17:53

pullapprove4 bot added PA: All Contributors pending PA: Maintainers pending labels Dec 2, 2025

Merge branch 'master' into appinf

20cd5ed

Paillat-dev requested changes Dec 4, 2025

View reviewed changes

pullapprove4 bot removed PA: All Contributors pending PA: Maintainers pending labels Dec 4, 2025

Lumabots and others added 2 commits December 5, 2025 09:53

feat: add ApplicationEventWebhookStatus enum and update AppInfo to us…

ef0cb75

…e it

style(pre-commit): auto fixes from pre-commit.com hooks

5f939dd

	def _decode_ctx(value: dict \| None) -> AppInstallParams \| None:
	def _decode_ctx(value: dict[Any, Any] \| None) -> AppInstallParams \| None:

	def _to_payload(self) -> dict[int, dict[str, object] \| None]:
	def _to_payload(self) -> dict[int, dict[str, Any] \| None]:

	payload: dict[int, dict[str, object] \| None] = {}
	payload: dict[int, dict[str, Any] \| None] = {}

	def _to_payload(self) -> dict[str, object]:
	def _to_payload(self) -> dict[str, Any]:

Uh oh!

feat: Add support for editing application info and new fields #2994

Are you sure you want to change the base?

feat: Add support for editing application info and new fields #2994

Conversation

Lumabots commented Nov 7, 2025

Summary

Information

Checklist

Uh oh!

pycord-app bot commented Nov 7, 2025

Uh oh!

Soheab left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Nov 25, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Lumabots commented Nov 29, 2025

Uh oh!

Paillat-dev commented Nov 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants