Skip to content

feat: ✨ add unknown sticker format type to StickerFormatType enum #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: ✨ add unknown sticker format type to StickerFormatType enum #58

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
caa3041
:memo: CHANGELOG
Paillat-dev Aug 3, 2025
0362239
fix: update default return value for unknown sticker formats
Paillat-dev Aug 4, 2025
bfd6d0b
:memo: CHANGELOG
Paillat-dev Aug 4, 2025
1d149ec
fing precommit
Paillat-dev Aug 4, 2025
049517e
chore(deps): upgrade pre-commit hook astral-sh/ruff-pre-commit to v0.…
renovate[bot] Sep 3, 2025
aba3f15
Merge branch 'master' into feat/unknown-sticker-format
Paillat-dev Sep 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ repos:
- id: end-of-file-fixer
exclude: \.(po|pot|yml|yaml)$
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.12.9
rev: v0.12.11
hooks:
- id: ruff
args: [ --fix ]
Expand Down
4 changes: 4 additions & 0 deletions CHANGELOG-V3.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,10 @@ release.

### Added

- `StickerFormatType.file_extension` will be `None` instead of `"png"` when an unknown
sticker format is encountered.
[#58](https://github.com/Pycord-Development/pycord-next/pull/58)

### Fixed

### Changed
Expand Down
5 changes: 2 additions & 3 deletions discord/enums.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,15 +638,14 @@ class StickerFormatType(Enum):
gif = 4

@property
def file_extension(self) -> str:
def file_extension(self) -> str | None:
lookup: dict[StickerFormatType, str] = {
StickerFormatType.png: "png",
StickerFormatType.apng: "png",
StickerFormatType.lottie: "json",
StickerFormatType.gif: "gif",
}
# TODO: Improve handling of unknown sticker format types if possible
return lookup.get(self, "png")
return lookup.get(self)


class InviteTarget(Enum):
Expand Down