set the default number of frames of the ring buffer to 10 #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because a higher number induce an issue on the tl_camera_arm method when using CS126MU camera ???
Contributor
Author
|
@rgeneaux could you see if hardcoding this number 10 is an issue for you? Or should we open it as a user settable parameter ? but how can we inform that sometimes higher than 10 is good and sometimes not?? |
rgeneaux
approved these changes
Oct 21, 2025
Contributor
rgeneaux
left a comment
rgeneaux
left a comment
There was a problem hiding this comment.
I see no difference in behavior nor in frame rate (tested on a Zelux CMOS) so let's go for it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because a higher number induce an issue on the tl_camera_arm method when using CS126MU camera ???
I tried to dig out the differences but could not assess it. Worked fine so far with another camera CS165CU.