Skip to content

fix: floating-point equality, unused param, duplicate calls, stdout safety, missing test#81

Open
Xenon010101 wants to merge 1 commit into
Py-Contributors:mainfrom
Xenon010101:fix/various-bugs
Open

fix: floating-point equality, unused param, duplicate calls, stdout safety, missing test#81
Xenon010101 wants to merge 1 commit into
Py-Contributors:mainfrom
Xenon010101:fix/various-bugs

Conversation

@Xenon010101
Copy link
Copy Markdown

Summary

Fixed 6 bugs:

  1. is_one_one.py — Floating-point equality (== 1) fails on IEEE 754 rounding; use math.isclose
  2. is_one_one.py — Unused parameter Anik_one(a) immediately overwritten
  3. is_one_one.py — Duplicate function call (is_one_using_interdimensional_tax_fraud called twice instead of Anik_one)
  4. is_one_one.py — Same duplicate in main()
  5. test_core.py — Unsafe sys.stdout buffer reassignment (data loss risk on Windows)
  6. test_core.py — Missing test for Anik_one (added)

@github-actions
Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

Copy link
Copy Markdown
Member

@itsdakshjain itsdakshjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for contribution @Xenon010101 , if you are genuinely doing code cleanups, there are more you can do in these files...otherwise i willl merge it upon your response as it is

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants