Skip to content

feat: load modular one methods#56

Open
nvphungdev wants to merge 1 commit into
Py-Contributors:mainfrom
nvphungdev:feat/modular-method-loader
Open

feat: load modular one methods#56
nvphungdev wants to merge 1 commit into
Py-Contributors:mainfrom
nvphungdev:feat/modular-method-loader

Conversation

@nvphungdev
Copy link
Copy Markdown

Summary

  • add a methods/ package with sample_method.py showing moved validation functions
  • dynamically load is_one... functions from Python files inside methods/
  • update the contribution docs and tests for the modular loader path

Testing

  • python3 test_core.py
  • .venv/bin/python -m pytest test_core.py
  • python3 -m py_compile is_one_one.py test_core.py methods/__init__.py methods/sample_method.py
  • git diff --check

Closes #55

@github-actions
Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

Copy link
Copy Markdown
Member

@itsdakshjain itsdakshjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @nvphungdev , nice addition of methods and its sample with update in respective is_one_one.py but i have just merged unit testing and negative testing in test_core.py which is causing conflict and also would like to see how the overall codebase of this pr changes acc to that. can you do changes nd share your thoughts

thanks for contribution, can ask for help if stuck
Happy to merge anyways

@nvphungdev nvphungdev force-pushed the feat/modular-method-loader branch from 5cbe32b to 4a1b325 Compare May 19, 2026 04:28
@nvphungdev
Copy link
Copy Markdown
Author

Rebased this branch onto current main and folded the dynamic-loader checks into the new unittest structure.

Checked with:

  • python3 -m unittest test_core.py
  • python3 test_core.py
  • git diff --check

@github-actions
Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

Copy link
Copy Markdown
Member

@itsdakshjain itsdakshjain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking great and as per issue i know, you did 2 sample but can you specify what needs to done after merger of this pr so i can be sure of what changes need to be made for all funtions . and how will it connect with test_core.py and verify.yml (currently its dumb commenting everything ) @nvphungdev
thanks for your patience regarding this pr and contribution

Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
@nvphungdev nvphungdev force-pushed the feat/modular-method-loader branch from 4a1b325 to 24e9ee3 Compare May 19, 2026 11:52
@github-actions
Copy link
Copy Markdown

✅ Logic Verified!

The Automated Logic Suite has confirmed that 1 is still 1.

  • Environment: Ubuntu-latest
  • Status: Mathematical Sanity Confirmed

You are safe to merge this chaos.

@nvphungdev
Copy link
Copy Markdown
Author

Rebased on current main again and kept the new unittest/negative-test changes from upstream.

What this changes after merge:

  • new community checks can be added as is_one... functions in methods/*.py
  • is_one_one.py loads those methods into the public module, so existing imports and main() still work
  • test_core.py now covers both the current core checks and the dynamic loader path
  • verify.yml still runs python test_core.py, so any method-loader regression fails CI

I also added a stable comment_tag to the success/failure comment steps in verify.yml, so future CI runs should update the same bot comment instead of adding another duplicate one.

Checked with:

  • python3 -m unittest test_core.py
  • python3 test_core.py
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

infrastructure: Create a methods/ directory for modular community contributions

2 participants