feat: load modular one methods#56
Conversation
✅ Logic Verified!The Automated Logic Suite has confirmed that 1 is still 1.
You are safe to merge this chaos. |
itsdakshjain
left a comment
There was a problem hiding this comment.
hi @nvphungdev , nice addition of methods and its sample with update in respective is_one_one.py but i have just merged unit testing and negative testing in test_core.py which is causing conflict and also would like to see how the overall codebase of this pr changes acc to that. can you do changes nd share your thoughts
thanks for contribution, can ask for help if stuck
Happy to merge anyways
5cbe32b to
4a1b325
Compare
|
Rebased this branch onto current main and folded the dynamic-loader checks into the new unittest structure. Checked with:
|
✅ Logic Verified!The Automated Logic Suite has confirmed that 1 is still 1.
You are safe to merge this chaos. |
itsdakshjain
left a comment
There was a problem hiding this comment.
looking great and as per issue i know, you did 2 sample but can you specify what needs to done after merger of this pr so i can be sure of what changes need to be made for all funtions . and how will it connect with test_core.py and verify.yml (currently its dumb commenting everything ) @nvphungdev
thanks for your patience regarding this pr and contribution
Signed-off-by: nvphungdev <283886185+nvphungdev@users.noreply.github.com>
4a1b325 to
24e9ee3
Compare
✅ Logic Verified!The Automated Logic Suite has confirmed that 1 is still 1.
You are safe to merge this chaos. |
|
Rebased on current What this changes after merge:
I also added a stable Checked with:
|
Summary
methods/package withsample_method.pyshowing moved validation functionsis_one...functions from Python files insidemethods/Testing
python3 test_core.py.venv/bin/python -m pytest test_core.pypython3 -m py_compile is_one_one.py test_core.py methods/__init__.py methods/sample_method.pygit diff --checkCloses #55