Skip to content

build: .NET 10 upgrade#485

Open
runejo wants to merge 15 commits intomainfrom
build-dotnet-10
Open

build: .NET 10 upgrade#485
runejo wants to merge 15 commits intomainfrom
build-dotnet-10

Conversation

@runejo
Copy link
Copy Markdown
Member

@runejo runejo commented Nov 25, 2025

No description provided.

@runejo
Copy link
Copy Markdown
Member Author

runejo commented Nov 25, 2025

This draft PR is still missing the openapi upgrade

  Swashbuckle.AspNetCore              9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.Annotations  9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.Newtonsoft   9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.SwaggerGen   9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.SwaggerUI    9.0.6 -> 10.0.1

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@runejo runejo added the dependencies Pull requests that update a dependency file label Apr 9, 2026
runejo added 9 commits April 17, 2026 12:00
@runejo
Merge branch 'main' into build-dotnet-10
83bdddc
@runejo
chore: update package references to version 10.0.6 for Microsoft.Exte…
d03f363 
…nsions and System.IO libraries
@runejo
chore: update .NET SDK and ASP.NET base images to version 10.0.202 an…
e9df999 
…d 10.0.6 respectively; add System.Security.Cryptography.Xml package reference
@runejo
temporary set TreatWarningsAsErrors to False for Release configuratio…
b0b81ce 
…n to build docker image
@runejo
chore: remove unused Swagger filters and update Swashbuckle.AspNetCor…
6349d43 
…e to version 10.1.7
@runejo
Revert "chore: remove unused Swagger filters and update Swashbuckle.A…
965ee61 
…spNetCore to version 10.1.7"

This reverts commit 6349d43.
@runejo
chore: remove unused Swagger filters to streamline API documentation
f37be47
@runejo
chore: enable TreatWarningsAsErrors for Debug and Release configurati…
3ccc46a 
…ons; remove System.Security.Cryptography.Xml package reference
@runejo
chore: remove unused log4net package reference from project file
a5bea6e
@runejo
Copy link
Copy Markdown
Member Author

runejo commented Apr 17, 2026

This draft PR is still missing the openapi upgrade

  Swashbuckle.AspNetCore              9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.Annotations  9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.Newtonsoft   9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.SwaggerGen   9.0.6 -> 10.0.1
  Swashbuckle.AspNetCore.SwaggerUI    9.0.6 -> 10.0.1

I think we should stick to Swashbuckle v9 until aspnetcore Generator is updated. There are several things to consider in the new version Migrating to Swashbuckle.AspNetCore v10

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Apr 17, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@runejo runejo marked this pull request as ready for review April 17, 2026 15:16
likp
likp reviewed Apr 20, 2026
View reviewed changes
Comment thread PxWeb/PxWeb.csproj

<PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'">
<TreatWarningsAsErrors>True</TreatWarningsAsErrors>
<TreatWarningsAsErrors>False</TreatWarningsAsErrors>
Copy link
Copy Markdown
Contributor

@likp likp Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we not treat waringing as errors anymore. Do we get to many warninga?

Copy link
Copy Markdown
Member Author

@runejo runejo Apr 21, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's just temporary until we have released a patched PCAxis.Sql nuget :-)

likp
likp reviewed Apr 20, 2026
View reviewed changes
Comment thread PxWeb/Filters/Api2/BasePathFilter.cs
Copy link
Copy Markdown
Contributor

@likp likp Apr 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this is not in use?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@likp likp likp left review comments

@MikaelNordberg MikaelNordberg Awaiting requested review from MikaelNordberg MikaelNordberg is a code owner

@JohannesFinsveen JohannesFinsveen Awaiting requested review from JohannesFinsveen JohannesFinsveen is a code owner

@oyessb oyessb Awaiting requested review from oyessb oyessb is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@runejo @likp