feature/PxWeb2-896 New layout with virtualized separated mobile and desktop tables#1187
Draft
SjurSutterudSagen wants to merge 50 commits intomainfrom
Conversation
…nt. Fixes in NavigationDrawer layout for smaller devices.
…onent in TableViewer
…lection and table information
…ents for improved layout
Adjusted some paddings and width calculation
adjust maxwidth from 1320 to 1288 in contentAndFooterContainer
…ents to use HTMLElement type
Changed the setup of the motion aniimations to start with a different background color in the NavBar. This simplified the logic a bit since they are now the same in the NavBar and NavRail. Also fixed a type error with motion in the component.
…l instead of within a div. Simplified Footer component scroll-to-top functionality.
…https://github.com/PxTools/PxWeb2 into feature/PxWeb2-896-new-layout-with-virtualized-table
… container virtualizers
…bile and desktop layouts
Branch Deployment to Cloudflare Pages🚛 Preview URL: https://36d981b3.pxweb2.pages.dev |
Refactor Desktop and Mobile Virtualized Tables for Improved Data Handling and Rendering - Enhanced DesktopVirtualizedTable to manage column virtualization and row rendering more efficiently. - Introduced new utility functions for building row entries and rendering body rows in both desktop and mobile tables. - Updated MobileVirtualizedTable to streamline row entry creation and rendering logic. - Added support for handling cases with no stub data in both table components. - Improved accessibility by ensuring proper ARIA labels and headers are set for table cells. - Refactored code for better readability and maintainability, including the use of memoization for performance optimization.
…ata structure with definitions
…ed-separated-mobile-and-desktop-tables
…Complexity Implement row virtualization settings and update tests for desktop and mobile tables
SjurSutterudSagen
changed the title
- Added `TableCellData.ts` to encapsulate logic for resolving formatted values and headers for data cells. - Refactored `TableDesktopVirtualized.tsx` and `TableMobileVirtualized.tsx` to utilize `resolveDataCell` for improved data handling. - Implemented `walkStubTree` in `TableStubTraversal.ts` for structured traversal of stub dimensions. - Updated rendering logic in both desktop and mobile virtualized tables to accommodate new data resolution methods. - Minor adjustments in `TableViewer.tsx` for scroll container setup.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP