-
Notifications
You must be signed in to change notification settings - Fork 5
회원가입 및 로그인 API #158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
회원가입 및 로그인 API #158
Conversation
- users, resumes table 추가 - docker, mysql 스크립트 추가
- 로그인 토큰 생성하기 위해 환경변수 설정 - auth/(sign-up/login)에 각각 회원가입 및 로그인 구현
This reverts commit e7642e3.
soohyunme
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
리뷰 코멘트 남겨뒀습니다 !
참고해주시고 나머지는 좋은 것 같습니다 !
.env.example
Outdated
| MYSQL_PASSWORD="root" | ||
| MYSQL_HOST="localhost" | ||
| MYSQL_DATABASE="jobpt" | ||
| SECRET_KEY=3c86b1aa566a885dd571729170794eea7354cd5af85670bd89fa741852b5a897 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# DB
MYSQL_USER=your_mysql_user
MYSQL_PASSWORD=your_mysql_password
MYSQL_HOST=localhost
MYSQL_DATABASE=jobpt
# JWT Secret (필수)
# 아래 명령어로 랜덤 값 하나 생성해서 사용하세요.
# python -c "import secrets; print(secrets.token_hex(32))"
SECRET_KEY=change_me
- root 보다 좀 더 sample 유저 느낌을 줄 수 있도록 변경
- 위와 같은 형식으로
README.md의 내용을.env.example에 넣는 건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 좋습니다 수현님 의견 감사합니다!!👍👍 반영해서 커밋 추가로 올리겠습니다
backend/main.py
Outdated
| # nltk.download("punkt") | ||
| # nltk.download("punkt_tab") | ||
| uvicorn.run("main:app", host="0.0.0.0", port=8000) | ||
| uvicorn.run("main:app", host="0.0.0.0", port=8000, reload=True) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
개발 환경일때만 reload=True 해야되지 않을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
꼼꼼하게 확인해주셔서 감사해요... 테스트 하다가 놓친 것 같숩니다... 같이 반영해놓을게용!
|
👍 |
name: "🚀 Pull Request"
about: PR 생성 시 기본 템플릿
labels: 'needs-review'
📝 PR 타입
📜 설명
MySQL(Docker)로 DB 를 생성, 회원가입 및 로그인 API 작성하였습니다.
엮인 이슈
🔨 작업 내용
/auth/sign-up에 회원가입 api 작성/auth/login에 로그인 api 작성📸 스크린샷
🧑💻 테스트 결과
전체 테스트 코드(Python)
📅 체크리스트