LogA: Make trikita.log invisible to ARTistGUI#6
Open
partipan-dot wants to merge 2 commits intoProject-ARTist:developfrom
partipan-dot:trikita_logging
Open
LogA: Make trikita.log invisible to ARTistGUI#6partipan-dot wants to merge 2 commits intoProject-ARTist:developfrom partipan-dot:trikita_logging
partipan-dot wants to merge 2 commits intoProject-ARTist:developfrom
partipan-dot:trikita_logging
Conversation
Member
|
I am fine with this, seems like a good idea to enforce the usage of the LogA API. |
Author
|
No, this change breaks ARTistGUI directly after merging this PR. ARTistGUI calls logging methods from trikita.log in several places. Project-ARTist/ArtistGui#62 replaces all calls to methods from trikita.log and android.util.log. |
Dexterous doesn't depend on the design support library. It doesn't jUnit, mockito or hamcrest either.
The methods in LogA respect the set log level and ARTistGui should depend only on LogA. It shouldn't be able to call anything directly from trikita.log.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging methods in LogA respect the set log level and ARTistGuishould depend only on LogA. It shouldn't be able to call trikita.log directly.
This change depends on: Project-ARTist/ArtistGui#62