Skip to content

Conversation

@ilicfilip
Copy link
Collaborator

@ilicfilip ilicfilip commented Oct 3, 2025

Implements #649

Things to do:

  • Replace placeholder and temporary text
  • Improve styling, for example when plugin is installed
  • Add data collector for checking the number of PDFs (so query is not ran on every page load)

EDIT:
XML Sitemap for PDFs for Yoast SEO requires Yoast SEO plugin to be active, do we skip suggesting it if Yoast SEO is not active or nudge user to activate it as well?

If we do suggest user to activate Yoast SEO we probably should check if other SEO plugins are active first, so which ones to include in the check?

@ilicfilip ilicfilip added this to the 1.9.0 milestone Oct 3, 2025
@ilicfilip ilicfilip added the enhancement New feature or request label Oct 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2025

Test on Playground
Test this pull request on the Playground
or download the zip

@aristath
Copy link
Member

@ilicfilip what's missing on this one? Is it ready for review, or still a draft?

@ilicfilip
Copy link
Collaborator Author

@aristath , decision on:

_XML Sitemap for PDFs for Yoast SEO requires Yoast SEO plugin to be active, do we skip suggesting it if Yoast SEO is not active or nudge user to activate it as well?

If we do suggest user to activate Yoast SEO we probably should check if other SEO plugins are active first, so which ones to include in the check?_

@aristath
Copy link
Member

@ilicfilip I think both of these were already addressed in #676 yesterday 👍

@ilicfilip
Copy link
Collaborator Author

I have updated the task so:

  • It will be created if user has more than 10 PDF files in the media library
  • The first step recommends the premium PDF Library plugin
  • If the user doesnt have Yoast SEO active there will be no 2nd step and user can collect the point
  • If the Yoast SEO is active user can advance to the 2nd step from where it can install / activate the PDF Sitemap add on.

What needs to be done:

  • Priority needs to be set correctly, so this task loads after the "Install SEO plugin" task
  • Wording needs to be adjusted, as it is mostly Lorem ipsum text now

@ilicfilip ilicfilip marked this pull request as ready for review October 22, 2025 08:19
@aristath
Copy link
Member

Should this task only be added if the user has Yoast-SEO installed? 🤔
If they have some other SEO plugin installed this doesn't make a lot of sense

@ilicfilip
Copy link
Collaborator Author

Yes, but "The first step recommends the premium PDF Library plugin"

So we recommend something in any case

@aristath
Copy link
Member

@ilicfilip I pushed 2 commits here:

  1. Fix inconsistent cache key (pdf_files_count, pdf_count)
  2. Replaced lips text with a reasonable description:

Adding an XML sitemap for your PDF files helps search engines discover and index them more effectively. This can improve visibility in search results and drive more organic traffic to your valuable PDF content.

@aristath aristath merged commit 6e498bb into develop Oct 24, 2025
28 checks passed
@aristath aristath deleted the filip/v19/improve-pdf-handling branch October 24, 2025 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants