feat: Support flow_name from prefect.yaml. (#1)#283
Open
jthetzel wants to merge 1 commit into
Open
Conversation
* feat: Support `flow_name` from prefect.yaml. * docs: Make docs * refactor: Change flowRun to flow_run
Author
|
Container image available here: jthetzel/prefect-operator:9fe4668 |
mitchnielsen
requested changes
Jun 23, 2026
mitchnielsen
left a comment
Member
There was a problem hiding this comment.
Thanks for this @jthetzel! One small suggestion.
Comment on lines
-3
to
-4
| //go:coverage ignore | ||
|
|
Member
There was a problem hiding this comment.
Suggested change
| //go:coverage ignore | |
| //go:coverage ignore | |
Member
There was a problem hiding this comment.
One small fix: this file shouldn't drop //go:coverage ignore. The Makefile generate target re-adds it on every run (sed -i '1a\\n//go:coverage ignore' …), and make test depends on generate, so the next regen will revert this. While committed it makes the generated DeepCopy code count against coverage (the suite uses -coverpkg ./api/v1/...).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for
flow_runto specify a deployment's flow name. For background, see #280 .Given this flow:
And this (pseudo) manifest:
Before this branch, deployment is named
With this branch, deployment is named