Skip to content

feat: Support flow_name from prefect.yaml. (#1)#283

Open
jthetzel wants to merge 1 commit into
PrefectHQ:mainfrom
c-core-labs:main
Open

feat: Support flow_name from prefect.yaml. (#1)#283
jthetzel wants to merge 1 commit into
PrefectHQ:mainfrom
c-core-labs:main

Conversation

@jthetzel

Copy link
Copy Markdown

Add support for flow_run to specify a deployment's flow name. For background, see #280 .

Given this flow:

@flow(name="flow-foo")
def flow_foo():
    print("bar")

And this (pseudo) manifest:

apiVersion: prefect.io/v1
kind: PrefectDeployment
metadata:
 name: deployment-foo
 namespace: prefect
spec:
 deployment:
   flow_name: flow-run
   entrypoint: app.foo:flow_run

Before this branch, deployment is named

flow_foo/deployment-foo

With this branch, deployment is named

flow-foo/deployment-foo

* feat: Support `flow_name` from prefect.yaml.

* docs: Make docs

* refactor: Change flowRun to flow_run
@jthetzel jthetzel requested review from a team as code owners June 22, 2026 21:11
@jthetzel

Copy link
Copy Markdown
Author

@mitchnielsen mitchnielsen self-requested a review June 23, 2026 20:07

@mitchnielsen mitchnielsen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @jthetzel! One small suggestion.

Comment on lines -3 to -4
//go:coverage ignore

@mitchnielsen mitchnielsen Jun 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
//go:coverage ignore
//go:coverage ignore

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small fix: this file shouldn't drop //go:coverage ignore. The Makefile generate target re-adds it on every run (sed -i '1a\\n//go:coverage ignore' …), and make test depends on generate, so the next regen will revert this. While committed it makes the generated DeepCopy code count against coverage (the suite uses -coverpkg ./api/v1/...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants