feat: require reason and audit trail for verification override#574
Merged
greatest0fallt1me merged 1 commit intoMay 29, 2026
Conversation
- Reject empty reason in admin_override_verification (Error::InvalidInput) - Append immutable AuditRecord with OracleVerificationOverride action, capturing old_result, new_result, and reason in the details map - Emit AdminOverrideEvent (market_id, admin, old/new result, reason, timestamp) via a dedicated 'adm_ovrd' topic for off-chain monitors - Add AdminOverrideEvent struct and emit_admin_override to events.rs - Add OracleVerificationOverride variant to AuditAction enum - Auth (require_primary_admin) precedes all storage writes - 6 tests in override_audit_tests.rs covering: empty reason rejection, audit record content, chain integrity, market state, non-admin rejection, and no-partial-state guarantee on auth failure
|
@Vvictor-commits Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #548
Summary
Closes the oracle-manipulation accountability gap in
admin_override_verification. Every override now requires a non-empty justification, appends an immutable audit-trail record, and emits a dedicated event for off-chain monitors.Changes
audit_trail.rsOracleVerificationOverridevariant toAuditActionenumevents.rsAdminOverrideEventstruct (market_id,admin,old_result,new_result,reason,timestamp)EventEmitter::emit_admin_overridewith topic keyadm_ovrdlib.rsrequire_primary_admin— auth before any storage writereason→Err(InvalidInput)before touching storageold_result, setsoracle_result+state = Resolved, savesold_result/new_result/reasonAdminOverrideEventoverride_audit_tests.rs(new,#[cfg(test)])Acceptance Criteria
test_override_rejects_empty_reasontest_override_appends_audit_recordverify_audit_integritypasses after overridetest_override_preserves_audit_integritytest_override_resolves_markettest_override_rejects_non_admintest_override_no_partial_state_on_auth_failureTesting