Conversation
1edc49f to
cc2586a
Compare
cc2586a to
328c878
Compare
|
OK, just one showstopper. Extant "stack integration" question has gone backwards. This needs a fix before I can merge.
I have about an hour into rearranging commits and testing. Please do not change any commits here. You can tell me (clearly) about a minor edit and I will do it, or add on a new commit (which I will cherry-pick into what I have going). General comments in next message - none meant for action on this PR. |
|
Some general comments. I'll start more general and work my way into minor nit-picking. ;-)
Yes, I keep saying I should write these up in The Guide... Thanks for all your work on this. You knew it was going to be a big job, no? ;-) |
|
Hi Rob, thanks for your quick response! I cannot reproduce any of these issues, the STACK questions build fine for me:
The STACK integration question static version the I get when running I do remember having the issue with tags inside the I also noticed that I didn't update the API URL for the sample article to https://stack-api.maths.ed.ac.uk (now that this official one is working), but the one we have in the sample article is working for me too. |
The Regexes are not actually capturing XML elements, they are mostly to convert MathJax to PreText, and replace STACK-specific blocks (e.g. input fields, feedback fields) with their PreText equivalent. I do parse the HTML that is returned by the API using lxml to convert commonly used HTML tags.
Thanks, I'll keep that in mind for the future. Let me know if you want me to update the commit messages or if you're going ahead with that yourself.
As above, let me know if you want me to reorder the commits. I'll keep it in mind for the future. |
|
We cannot do development with the CLI - I thought I have made this clear. It lags the main repository, and it caches some results. Please do careful testing (before/after) with the I never have any problem picking up changes due to a forced push. So I picked this up fresh, made no changes, and generated static versions. The suspect Did you happen to see #2787? Might it have some effect? More to say, but we need to get over this first. |
328c878 to
2fef0b4
Compare
|
Hi Rob, I rebased onto main to see if the issue is related to #2787, but no dice. (I updated the commit messages in the process and the STACK API URL in the sample article.) The only issue I was able to reproduce was "The provided file does not contain valid XML" in the HTML version for the integration question. It seems like the API didn't like the namespace in that question (there was no namespace in the minimal STACK example, just the sample article). I'm surprised it still produced a sensible static version. I removed that namespace now. Whatever I try, I'm unable to reproduce the I made sure my working tree is clean. I'm running I'm using Python 3.10.12, with the following libraries: |

Adds support for a variety of STACK features, such as most existing input types and images, and improves error handling. A few example questions have been added to the sample article. (I plan to create a STACK example in the examples folder with a more detailed test suite.)
Also fixes a bug in the HTML rendering of STACK questions featuring multi-line latex, see #2778